feat: refactor importer feedback #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We basically make the all import chain return the results as promise, so the importer can act at the end of the process and: - zoom only to the imported data (in case the layer already as some) - display a counter of imported data when import is successfull - display an alert when nothing has been imported cf #564
davidbgk
reviewed
Dec 12, 2024
| async importFromFiles(files, type) { | ||
| let all = [] | ||
| for (const file of files) { | ||
| const features = await this.importFromFile(file, type) |
There was a problem hiding this comment.
I wonder if the promise.all() pattern could be in use here 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We basically make the all import chain return the results as promise, so the importer can act at the end of the process and:
cf #564