404's when using ImageProcessor / other file systems #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeavon
approved these changes
Nov 4, 2021
|
Thanks, @callumbwhyte 🥳 If anyone wants to test the NuGet pre-release - https://www.myget.org/feed/umbraco-packages/package/nuget/UmbracoFileSystemProviders.Azure.Media/3.0.2-alpha-000517 |
|
Released in v3.0.2 Thanks @callumbwhyte #h5yr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #202, the recent v3 version doesn't play nicely when using ImageProcessor blob cache (or actually any file system that isn't the media file system).
It seems etag support was added in #179, which called some additional methods on the file system within the virtual file. If the blob does not exist
GetPropertiesthrows a "BlobNotFound" error.Despite a file system being passed in to the constructor of the virtual file class, for a long time the code has been fetching the media file system out of Umbraco's service locator instead. As such, if the virtual file being requested doesn't exist in the media file system you get an error.