Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter on published state for media descendent queries #18214

Open
wants to merge 1 commit into
base: v15/dev
Choose a base branch
from

Don't filter on published state for media descendent queries.

a19dc60
Select commit
Loading
Failed to load commit list.
Open

Don't filter on published state for media descendent queries #18214

Don't filter on published state for media descendent queries.
a19dc60
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) failed Feb 4, 2025 in 4m 1s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (5.23 -> 5.22)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method PublishedContentExtensions.cs: EnumerateDescendantsOrSelfInternal

✅ Improving Code Health:

  • Code Duplication PublishedContentExtensions.cs

Annotations

Check notice on line 1 in src/Umbraco.Core/Extensions/PublishedContentExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

ℹ Getting worse: Lines of Code in a Single File 

The lines of code increases from 2848 to 2849, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in src/Umbraco.Core/Extensions/PublishedContentExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ Getting better: Code Duplication 

reduced similar code in: EnumerateAncestorsOrSelfInternal,EnumerateDescendantsOrSelfInternal. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 4506 in src/Umbraco.Core/Extensions/PublishedContentExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ Getting worse: Complex Method 

EnumerateDescendantsOrSelfInternal increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis