Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce CPU time when initiating RepositoryCacheKeys #18267

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

Conversation

Henr1k80
Copy link
Contributor

@Henr1k80 Henr1k80 commented Feb 7, 2025

Avoid an unneeded lookup in the Keys dictionary, when writing the newly created key.

This will reduce the CPU time spent in the important startup phase, where every cache is empty and everything is undergoing optimization and CPU heavy.

When the all keys have been written, the cost will be the same as before, as there is only lookup, no writing.

Prerequisites

  • I have added steps to test this contribution in the description below

Copy link

github-actions bot commented Feb 7, 2025

Hi there @Henr1k80, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Feb 10, 2025

Hello @Henr1k80,

Thanks for this new enhancement 👍
Someone from the team will have a look at it soon.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants