Fix: suggestion to #18398 #18399
Closed
Fix: suggestion to #18398 #18399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Lucene Package to 4.8.0-beta00017 * Add Package Reference --------- Co-authored-by: Sebastiaan Janssen <[email protected]>
(cherry picked from commit aa9f194)
…elivery API enabled (#18049)
…elivery API enabled (#18049)
…17818 ( Allow skipSelect blueprints only when one blueprint exists).
…into release/13.6
…latform detection. (#17373) Co-authored-by: Niels Lyngsø <[email protected]>
…e constraint does not exist. (#18063)
# Conflicts: # version.json
…rofile as a non-admin user (#18099) * Allowed retrieval of current user configuration when accessing user profile as a non-admin user. * Update src/Umbraco.Web.UI.Client/src/packages/user/user/repository/config/current-user-config.repository.ts --------- Co-authored-by: Jacob Overgaard <[email protected]>
Co-authored-by: Andy Butland <[email protected]>
Co-authored-by: Andy Butland <[email protected]>
… the other URLs for a published document. (#18135)
this fixes an issue where unused parameters were published as supported, but they were in fact never supported.
…18152) * Do not allow editing read-only properties by clicking their labels * Simplify the fix :) * Fix linting issue
# Conflicts: # version.json
…ucture to find parents when content is trashed. (#18355)
Example with a Style Select menu, with default (hard coded) options, similar to TinyMCE's unconfigured Style Select menu.
* wip entity-item-ref extension point * clean up * add ref list element * fix styling * Update document-item-ref.element.ts * move item repo * implement for input member * enable action slot * add null check * fix sorting again * fix sorting again * use member element * add draft styling back * move item repository * implement for user input * pass readonly and standalone props * make editPath a state * Update member-item-ref.element.ts * Fix user item ref * remove open button * remove unused * remove unused * check for section permission * add fallback element * add unique to modal route registration * add unique to modal router * remove unused id * Update member-item-ref.element.ts * append unique * compare with old value * only recreate the controller if the entity type changes * fix console warning * implement for document item ref * move logic to item data resolver * render draft as a tag * Update document-item-ref.element.ts * add more helpers to data resolver * export resolver * add observables * use observables in document item ref * add data resolver to tree item * add observable state * use const * align models * get icon from document type object * observe name and state * update observed value when a new item is set * update method name * update method names * pass model type * pass context type * use api prop instead of context * use api prop instead of context * fix types * use addUniquePaths for modal registration * fix type errors * Update index.ts * clean up * use path pattern
…of an HttpContext (#18369)
The unit test doesn't register the manifests, so we'll need to hard code loading the "Rich Text Essentials" extension.
* Tiptap: Adds custom button for Table Provides a popover with table menu actions. * Moved Table extension to its own folder * Extended the Tiptap `Table` extensions * Amended table toolbar actions to have `focus()` * Markup amends * Fix up Tiptap mock data * [WIP] Table column/row bubble menu * Tiptap, enabled content check for invalid markup * [WIP] Tiptap toolbar cascading menu items * Tiptap: relocated Block extension from "plugins" folder to "extensions" subfolder. * Table toolbar, moved the menu to the API * `UmbTiptapToolbarElementApiBase`, made `execute` concrete so that it becomes optional in extended classes. * Adds "default" toolbar element API which does nothing, but satisfies the extension loader controller. * `@ts-ignore` the `.showPopover()` and `.hidePopover()` calls * Updated Tiptap toolbar mock data-type.data to match TinyMCE toolbar layout. * Implemented "Cascading Menu Popover" as a standalone component * Reworked Table toolbar to use cascading menu * [WIP] Tiptap bubble menu * Adds Tiptap Cascading Menu Popover Example with a Style Select menu, with default (hard coded) options, similar to TinyMCE's unconfigured Style Select menu. * Small code tidy ups * Added "Insert Table" component * Removed Table Bubble Menu feature (temporarily) as its development isn't ready yet. * Removed `umb-tiptap-hover-menu` component as it wasn't been used. I expect this will become the bubble menu feature.
* use observablePart() * methods for variant ID * move into a gotManager method
…ype-validation Feature: block grid block type area/root validation
# Conflicts: # src/Umbraco.Web.UI.Client/package-lock.json # src/Umbraco.Web.UI.Client/package.json # version.json
* localizations * toggle validation --------- Co-authored-by: Mads Rasmussen <[email protected]>
* implement handleSelector configuration option for Sorter Controller * improve sorting of Content Type Groups * fix ignorerSelector * remove button from default ignorer * block grid type group sorter use handle * fix content type group sorter style * handle for Block List Entries * adjustments for block list and grid
* build(deps-dev): update storybook from 8.4.7 to 8.5.6 * build(deps): update tiptap from 2.11.2 to 2.11.5 * build(deps-dev): update eslint stuff to latest * build(deps): update element-internals-polyfill from 1.3.12 to 1.3.13 * build(deps): update marked from 15.0.6 to 15.0.7 * build(deps-dev): update vite from 5.4.14 to 6.1.0 * build(deps-dev): update globals to 15.15.0 (eslint dependency) * build(deps): update icon libraries to latest * build(deps-dev): update prettier from 3.4.2 to 3.5.1 * chore: generate consts * build(deps-dev): update test-related libraries * feat: copy over code from the tiny base64-js library because it is not exported as esm and has not been updated in 4 years * build(deps-dev): remove dependency from base64-js * build(deps-dev): upgrade rollup dependencies * test: disable tests for tinyce * build(deps-dev): update @babel/core to 7.26.9 * build(deps): update storybook to latest * build(deps-dev): update types * build(deps-dev): update typedoc from 0.27.6 to 0.27.7 * build(deps-dev): update @rollup/plugin-commonjs to latest * build(deps): import tiny as default and re-export as module and default to make everyone happy (and avoid commonjs pitfalls) * build: remove dependency on commonjs to build externals * build(deps-dev): uninstall @rollup/plugin-commonjs as it is no longer needed * test: reenable tinymce tests * fix: sets a default label this mistake was highlighted by the test runner * test: reenable tinymce tests * build: ignores autogenerated test file * build: adds github error logging to icon generator * build: log as error * build: adds tests for generate:* scripts * build: optimises icons with svgo to remove useless things like comments this also ensures that icons are unchanged when we upgrade icon library packages as they would normally include things like versions as comments in the files
* wip entity-item-ref extension point * clean up * add ref list element * fix styling * Update document-item-ref.element.ts * move item repo * implement for input member * enable action slot * add null check * fix sorting again * fix sorting again * use member element * add draft styling back * move item repository * implement for user input * pass readonly and standalone props * make editPath a state * Update member-item-ref.element.ts * Fix user item ref * remove open button * remove unused * remove unused * check for section permission * add fallback element * wip data mapper concept * add unique to modal route registration * add unique to modal router * remove unused id * Update member-item-ref.element.ts * append unique * compare with old value * only recreate the controller if the entity type changes * fix console warning * implement for document item ref * Added $type to ReferenceResponseModels * move logic to item data resolver * render draft as a tag * Update document-item-ref.element.ts * generate server models * add more helpers to data resolver * export resolver * add observables * use observables in document item ref * add data resolver to tree item * add observable state * use const * align models * get icon from document type object * observe name and state * update observed value when a new item is set * update method name * update method names * pass model type * pass context type * use api prop instead of context * use api prop instead of context * fix types * use addUniquePaths for modal registration * add fallback * use ref list * use reference items for media * make mapper name more generic * make default ref item always readonly * export types * temp fake variants array * add variants array to model * Update media-references-workspace-info-app.element.ts * add variants to model * hardcode fake array * register media ref item * update mock data * dot not allow conditions for data mappers * add data mapper * prefix info routes * prefix all ref routes * return undefined if there is not edit path * fix name collision * require data source identifier * use management api mapper * add management api mapper * fix type errors * Update index.ts * align naming * add todo comment * implement path pattern for media item * clean up * more clean up * sort imports * member edit path pattern * clean up --------- Co-authored-by: Sven Geusens <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]>
* add trash confirm modal * make referenceRepo optional + adjust styling * add referenceRepository to media trash action * wip entity-item-ref extension point * clean up * add ref list element * fix styling * Update document-item-ref.element.ts * move item repo * implement for input member * enable action slot * add null check * fix sorting again * fix sorting again * use member element * add draft styling back * move item repository * implement for user input * pass readonly and standalone props * make editPath a state * Update member-item-ref.element.ts * Fix user item ref * remove open button * remove unused * remove unused * check for section permission * add null check * change to use entity-item-ref element * register media item ref * add fallback element * show 3 references * wip data mapper concept * add unique to modal route registration * add unique to modal router * remove unused id * Update member-item-ref.element.ts * append unique * compare with old value * only recreate the controller if the entity type changes * fix console warning * implement for document item ref * Added $type to ReferenceResponseModels * move logic to item data resolver * render draft as a tag * Update document-item-ref.element.ts * generate server models * add more helpers to data resolver * export resolver * add observables * use observables in document item ref * add data resolver to tree item * add observable state * use const * align models * get icon from document type object * observe name and state * update observed value when a new item is set * update method name * update method names * pass model type * pass context type * use api prop instead of context * use api prop instead of context * fix types * use addUniquePaths for modal registration * add fallback * use ref list * use reference items for media * make mapper name more generic * make default ref item always readonly * export types * temp fake variants array * add variants array to model * Update media-references-workspace-info-app.element.ts * add variants to model * hardcode fake array * register media ref item * update mock data * dot not allow conditions for data mappers * add data mapper * prefix info routes * prefix all ref routes * return undefined if there is not edit path * add types for reference data source + repository * split trash with relation into its own action * render descendants with references * fix length check * set standalone attribute * implement for media * move trash * wip delete with relation * move to element * fix name collision * require data source identifier * use management api mapper * add management api mapper * fix type errors * Update index.ts * align naming * show references when deleting a document * Update delete-with-relation-modal.element.ts * use deleteWithRelation kind for media * clean up * localize trash * fix type * Update trash-with-relation.action.ts * override confirm methods in trash and delete actions * Update index.ts * export constants * Limit referenced-by document and media endpoints to references only. * Update document-reference-table.element.ts * add todo comment * implement path pattern for media item * clean up * more clean up * sort imports * member edit path pattern * clean up * remove unused variant id * export extension types * align naming --------- Co-authored-by: Sven Geusens <[email protected]> Co-authored-by: Andy Butland <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion on how to fix, but please test that it works as expected.
You need a custom view to see this.
Fixes #18398