-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin functional, initializers loader, additional methods to monads, refactor code, remove ReturnEngine class #12
Open
AnotherRegularDude
wants to merge
21
commits into
master
Choose a base branch
from
feature/add-dry-initializer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now supports plugins like sequel, can choose initializer, remove return engine
AnotherRegularDude
force-pushed
the
feature/add-dry-initializer
branch
from
January 11, 2025 08:48
e3b0c0c
to
52567c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sequel
If a parent class has already applied one of the initializers,
then an attempt to reapply initializer will cause an error for all of his children.
Therefore, I left the basic service class
Resol::Service
without the initializer at all, this is breaking behavior.You need something like
ApplicationSerivce < Resol::Service
Resol::Result
, because Result specific methods logic is more optimal.Also, add
#bind
and#fmap
methods.ReturnEngine
and add plugin instead.