Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tumor_normal output dir be tumor-normal? #559

Closed
alexiswl opened this issue Sep 18, 2024 · 2 comments · Fixed by #589
Closed

Should tumor_normal output dir be tumor-normal? #559

alexiswl opened this issue Sep 18, 2024 · 2 comments · Fixed by #589
Assignees
Labels
change request pipeline Workflow/Pipeline Manager

Comments

@alexiswl
Copy link
Member

Noticed we've go a few different case types going on here:

aws s3 ls "s3://pipeline-prod-cache-503977275616-ap-southeast-2/byob-icav2/production/analysis/"
                           PRE bclconvert-interop-qc/
                           PRE cttsov2/
                           PRE tumor_normal/
                           PRE umccrise/
                           PRE wgtsQc/

Should tumor_normal instead be 'tumor-normal' and wgtsQc be `wgts-qc'?

@alexiswl alexiswl self-assigned this Sep 18, 2024
@victorskl
Copy link
Member

All in favour.

@victorskl victorskl added the pipeline Workflow/Pipeline Manager label Sep 18, 2024
@victorskl
Copy link
Member

While at it, would be great if you could harmonise workflow_name (equivalent of type_name from Portal Workflow table) there too.

This is also related to object store output path^ prefix.

Something similar like SecondaryAnalysisHelper harmonisation or etc would be great.!

image

@alexiswl alexiswl linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request pipeline Workflow/Pipeline Manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants