Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set concurrency limits for icav2 copy jobs #580

Closed
alexiswl opened this issue Sep 30, 2024 · 1 comment · Fixed by #589
Closed

Set concurrency limits for icav2 copy jobs #580

alexiswl opened this issue Sep 30, 2024 · 1 comment · Fixed by #589
Assignees
Labels
feature New feature pipeline Workflow/Pipeline Manager

Comments

@alexiswl
Copy link
Member

Running 50 cttsov2 samples simultaneously is causing the copy jobs step to fall over.

A quick workaround is to front a lambda that can query how many of the copy sfns are running simultaneously and loop until this value is below a certain value and then allow the copy to occur.

A more comprehensive solution would be to centralise all copy jobs and place the step function behind an SQS queue with a max concurrency limit.
The complication here is that copy job would need to hang, not complete, after the job has been launched.
This may be resolved by placing the 'waitfortasktoken' into another step function that can place the initial task token to a database.
A second sqs is then needed to listen to copy job events completing, find the corresponding task token in the database, and unlock the initial copy sfn. Would also need to requeue failed jobs as well. The initial SFN would then also need to release the step function that initialised the sqs queue.

@alexiswl alexiswl added the feature New feature label Sep 30, 2024
@alexiswl alexiswl self-assigned this Sep 30, 2024
@reisingerf
Copy link
Member

Hm...

Running 50 cttsov2 samples simultaneously

Who's submitting those jobs?

@alexiswl alexiswl linked a pull request Oct 4, 2024 that will close this issue
@victorskl victorskl added the pipeline Workflow/Pipeline Manager label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature pipeline Workflow/Pipeline Manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants