Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filemanager): use version_id when calling S3 APIs #586

Closed
mmalenic opened this issue Oct 3, 2024 · 0 comments · Fixed by #587
Closed

fix(filemanager): use version_id when calling S3 APIs #586

mmalenic opened this issue Oct 3, 2024 · 0 comments · Fixed by #587
Assignees
@mmalenic
Labels
bug Something isn't working filemanager an issue relating to the filemanager

Comments

@mmalenic
Copy link
Member

mmalenic commented Oct 3, 2024

The filemanager should use version_id when calling S3 APIs like HeadObject, GetObjectTagging, and PutObjectTagging. Even though S3 is called on ingestion where the latest object for a key and bucket is probably always the right object, using the version_id is more correct, and it is available at that point in the code.
@mmalenic mmalenic self-assigned this Oct 3, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager bug Something isn't working labels Oct 3, 2024
@mmalenic mmalenic mentioned this issue Oct 3, 2024
Merged
@victorskl victorskl linked a pull request Oct 4, 2024 that will close this issue
fix(filemanager): version_id for S3 API calls #587
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmalenic mmalenic

Labels
bug Something isn't working filemanager an issue relating to the filemanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(filemanager): version_id for S3 API calls umccr/orcabus
1 participant
@mmalenic