feat: v6.3 upgrade handler and release notes (#2376)

* v6.3 release handler * release notes * lint * update release notes * Apply suggestions from code review Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Adam Moser <[email protected]> * update release notes * test --------- Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Adam Moser <[email protected]>
umee-network · Jan 3, 2024 · 007207a · 007207a
1 parent 16e06f8
commit 007207a
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 42 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -46,23 +46,25 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ## Unreleased
 
+## v6.3.0 - 2024-01-03
+
 ### Improvements
 
 - [2363](https://github.com/umee-network/umee/pull/2363) Upgrade Cosmos SDK to v0.47.7.
-- [2370](https://github.com/umee-network/umee/pull/2370) Add missing params to `uic/MsgGovUpdateQuota`.
+- [2370](https://github.com/umee-network/umee/pull/2370) Add missing params to `uibc/MsgGovUpdateQuota`.
 - [2374](https://github.com/umee-network/umee/pull/2374) Add symbol name to the x/uibc QueryAllOutflowsResponse `outflows` entry.
 
 ### Features
 
-- [2352](https://github.com/umee-network/umee/pull/2352) new `uibc/MissCounters` query
+- [2352](https://github.com/umee-network/umee/pull/2352) new `oracle/MissCounters` query
 - [2352](https://github.com/umee-network/umee/pull/2352) new `uibc/Inflows` query.
-- [2349](https://github.com/umee-network/umee/pull/2349) UIBC: adding ICS 20 memo handler.
-- [2369](https://github.com/umee-network/umee/pull/2369) Add query `leverage/RegisteredTokenMarkets` to fetch Registered Tokens and their Market Summaries for frontend in fewer queries.
+- [2349](https://github.com/umee-network/umee/pull/2349) UIBC: adding ICS 20 memo handler (disabled).
+- [2369](https://github.com/umee-network/umee/pull/2369) Add query `leverage/RegisteredTokensWithMarkets` to fetch Registered Tokens and their Market Summaries for frontend in fewer queries.
 
 ### Bug Fixes
 
 - [2358](https://github.com/umee-network/umee/pull/2358) metoken endblocker should be before oracle.
-- [2368](https://github.com/umee-network/umee/pull/2368) Add inflow amount to registered token. Previously, the inflow amount of the token was being overridden by the new inflow amount.
+- [2368](https://github.com/umee-network/umee/pull/2368) Fix inflow amount calculation. Previously, the inflow amount of the token was being overridden by the new inflow amount.
 - [2375](https://github.com/umee-network/umee/pull/2375) Ensure Umee and SDK account sequence setting changes the calling client.
 
 ### API Breaking

diff --git a/README.md b/README.md
@@ -61,10 +61,11 @@ See [Release procedure](CONTRIBUTING.md#release-procedure) for more information
 |    v6.0.x    |    ✓    | v0.46.14+  | v6.2.x |   ---   | umee/v2.1.6-1+ |            ---             |  v1.3.0   |
 |    v6.1.x    |    ✓    | v0.46.15+  | v6.2.x |   ---   |  umee/v2.1.7+  |            ---             |  v1.3.0   |
 |    v6.2.x    |    ✓    |  v0.47.6+  | v7.2.x |   ---   |  umee/v2.3.0   |            ---             |  v1.5.0   |
+|    v6.3.x    |    ✓    |  v0.47.7+  | v7.3.1 |   ---   |  umee/v2.3.0+  |            ---             |  v1.5.0   |
 
 #### Price Feeder
 
-Since `Price Feeder v2.1.0` the recommended oracle price feeder has been moved to this [repository](https://github.com/ojo-network/price-feeder/tree/umee) with the version prefix `umee/v.x`.
+Since `Price Feeder v2.1.0` the recommended oracle price feeder has been moved to this [repository](https://github.com/ojo-network/price-feeder/tree/umee) with the version prefix `umee/`.
 
 #### libwasmvm
 

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -6,43 +6,20 @@
 
 Release Procedure is defined in the [CONTRIBUTING](CONTRIBUTING.md#release-procedure) document.
 
-## v6.2.0
+## v6.3.0
 
 Highlights:
 
-- Umee chain upgrades to the latest stable Cosmos SDK v0.47
-- The `gov` module in in Cosmos SDK v0.47 has been updated to support a minimum proposal deposit at submission time. It is determined by a new parameter called `MinInitialDepositRatio`. When multiplied by the existing `MinDeposit` parameter, it produces the necessary proportion of coins needed at the proposal submission time. The motivation for this change is to prevent proposal spamming.
-  We set `MinInitialDepositRatio` to 10%.`
-- Added `meToken` WASM queries.
-- IBC Quota v2 mechanism
-  1. Outflows quota has been increased to `$1.6M` for total outflows and `$1.2M` per token outflows.
-  2. new lifting conditions is added: IBC outflows are possible if (1.) fails, but
-     - sum outflows of all tokens <= `$1M +  InflowOutflowQuotaRate * sum_of_all_inflows`;
-     - and token outflows <= `$0.9M + InflowOutflowQuotaRate * token_inflows`.
-       See [IBC Quota Design](./x/uibc/README.md#design) for more details.
+- Cosmos SDK v0.47.7 patch update.
+- New queries: `oracle/MissCounters`, `uibc/Inflows`, `uibc/QuotaExpires`, `leverage/RegisteredTokenMarkets`
+- Update `uibc/MsgGovUpdateQuota` Msg type to handle the new inflow parameters.
+- Update `uibc/QueryAllOutflowsResponse` to include denom symbol (token name) in every outflow.
 
 [CHANGELOG](CHANGELOG.md)
 
 ### Validators
 
-**Upgrade Title** (for Cosmovisor): **v6.2**.
-
-#### Price Feeder
-
-Price Feeder `< umee/v2.3.0` is not compatible with Cosmos SDK v0.47. Validators must update to `umee/v2.3.0` or newer.
-
-During the testnet upgrade, we noticed miss counters increasing dramatically. Please make sure your transactions are going through. If you see _out of gas_ in your transactions ([example](https://explorer.network.umee.cc/Canon-4/tx/74078158E2739CBF7EEA30D6BE673D207338E6686129717A4CED546F36F07CD7)), please increase `gas_adjustment` to `2.0` in your `price-feeder.toml`.
-
-We recommend to actively track your miss counters and making sure you follow the [latest currency-pairs config](https://github.com/ojo-network/price-feeder/blob/umee/umee-provider-config/currency-pairs.toml) (note the `umee` branch).
-
-#### libwasmvm update
-
-Our dependencies have been updated. Now the binary requires `libwasmvm v1.5.0`. When you build the binary from source on the server machine you probably don't need any change. However when you download a binary from GitHub, or from other source, make sure you update the `/usr/lib/libwasmvm.<cpu_arch>.so`. For example:
-
-- copy from `$GOPATH/pkg/mod/github.com/!cosm!wasm/[email protected]/internal/api/libwasmvm.$(uname -m).so`
-- or download from github `wget https://raw.githubusercontent.com/CosmWasm/wasmvm/v1.5.0/internal/api/libwasmvm.$(uname -m).so -O /lib/libwasmvm.$(uname -m).so`
-
-You don't need to do anything if you are using our Docker image.
+**Upgrade Title** (for Cosmovisor): **v6.3**.
 
 ### Upgrade instructions
 

diff --git a/app/upgrades.go b/app/upgrades.go
@@ -56,10 +56,10 @@ func (app UmeeApp) RegisterUpgradeHandlers() {
 	app.registerOutdatedPlaceholderUpgrade("v5.0")
 	app.registerOutdatedPlaceholderUpgrade("v5.1")
 	app.registerOutdatedPlaceholderUpgrade("v5.2")
-	app.registerUpgrade6(upgradeInfo)
+	app.registerUpgrade6_0(upgradeInfo)
 	app.registerOutdatedPlaceholderUpgrade("v6.1")
-
 	app.registerUpgrade6_2(upgradeInfo)
+	app.registerUpgrade("v6.3", upgradeInfo)
 }
 
 func (app *UmeeApp) registerUpgrade6_2(upgradeInfo upgradetypes.Plan) {
@@ -139,7 +139,7 @@ func (app *UmeeApp) registerUpgrade6_2(upgradeInfo upgradetypes.Plan) {
 	// app.registerNewTokenEmissionUpgrade(upgradeInfo)
 }
 
-func (app *UmeeApp) registerUpgrade6(upgradeInfo upgradetypes.Plan) {
+func (app *UmeeApp) registerUpgrade6_0(upgradeInfo upgradetypes.Plan) {
 	planName := "v6.0"
 	gravityModuleName := "gravity" // hardcoded to avoid dependency on GB module
 	emergencyGroup, err := sdk.AccAddressFromBech32("umee1gy3c8n2xysawysq2xf2hxn253srx4ehduevq6c")
@@ -231,8 +231,6 @@ func (app *UmeeApp) storeUpgrade(planName string, ui upgradetypes.Plan, stores s
 
 // registerUpgrade sets an upgrade handler which only runs module migrations
 // and adds new storages storages
-//
-//nolint:unused
 func (app *UmeeApp) registerUpgrade(planName string, upgradeInfo upgradetypes.Plan, newStores ...string) {
 	app.UpgradeKeeper.SetUpgradeHandler(planName, onlyModuleMigrations(app, planName))
 

diff --git a/sdkclient/tx/client.go b/sdkclient/tx/client.go
@@ -139,7 +139,8 @@ func (c *Client) BroadcastTx(idx int, msgs ...sdk.Msg) (*sdk.TxResponse, error)
 }
 
 func (c *Client) SetAccSeq(seq uint64) {
-	*c.txFactory = c.txFactory.WithSequence(seq)
+	// *c.txFactory = c.txFactory.WithSequence(seq)
+	c.txFactory.WithSequence(seq)
 }
 
 func (c *Client) WithAsyncBlock() *Client {

diff --git a/tests/e2e/setup/utils.go b/tests/e2e/setup/utils.go
@@ -294,7 +294,7 @@ func (s *E2ETestSuite) QueryIBCChannels(endpoint string) (bool, error) {
 func (s *E2ETestSuite) BroadcastTxWithRetry(msg sdk.Msg, cli client.Client) error {
 	var err error
 	// TODO: decrease it when possible
-	for retry := 0; retry < 10; retry++ {
+	for retry := 0; retry < 8; retry++ {
 		// retry if txs fails, because sometimes account sequence mismatch occurs due to txs pending
 		_, err = cli.Tx.BroadcastTx(0, msg)
 		if err == nil {
@@ -311,6 +311,7 @@ func (s *E2ETestSuite) BroadcastTxWithRetry(msg sdk.Msg, cli client.Client) erro
 		if err != nil {
 			return err
 		}
+		s.T().Log("expected sequence numbern", n)
 		cli.SetAccSeq(uint64(n))
 
 		time.Sleep(time.Millisecond * 300)