Skip to content

Commit

Permalink
fix(ugov amino): don't use proto.MessageName (#2473)
Browse files Browse the repository at this point in the history
* fix(ugov amino): don't use proto.MessageName

* comments

* changelog
  • Loading branch information
robert-zaremba authored Mar 26, 2024
1 parent 7be3d59 commit 41a826e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ Ref: https://keepachangelog.com/en/1.0.0/

## Unreleased

### Features

### Bug Fixes

- [2473](https://github.com/umee-network/umee/pull/2462) Correct x/ugov Amino registration for x/ugov messages (they don't have MessageName option).

## v6.4.0 - 2024-03-21

### Features
Expand All @@ -54,7 +60,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

- [2462](https://github.com/umee-network/umee/pull/2462) (x/leverage) Take `MaxModuleWithdraw` into account when computing user `MaxWithdraw`.
- [2462](https://github.com/umee-network/umee/pull/2462) (x/leverage) Take `MaxModuleWithdraw` into account when computing user `MaxWithdraw`.

## v6.4.0-beta1 - 2024-03-11

Expand Down
2 changes: 1 addition & 1 deletion x/auction/codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func init() {
amino.Seal()
}

// RegisterLegacyAminoCodec registers the necessary x/uibc interfaces and
// RegisterLegacyAminoCodec registers the necessary x/auction interfaces and
// concrete types on the provided LegacyAmino codec. These types are used for
// Amino JSON serialization.
func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
Expand Down
6 changes: 2 additions & 4 deletions x/ugov/codec.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package ugov

import (
"github.com/cosmos/gogoproto/proto"

"github.com/cosmos/cosmos-sdk/codec"
cdctypes "github.com/cosmos/cosmos-sdk/codec/types"
cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
Expand All @@ -26,11 +24,11 @@ func init() {
amino.Seal()
}

// RegisterLegacyAminoCodec registers the necessary x/uibc interfaces and
// RegisterLegacyAminoCodec registers the necessary x/ugov interfaces and
// concrete types on the provided LegacyAmino codec. These types are used for
// Amino JSON serialization.
func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
cdc.RegisterConcrete(&MsgGovUpdateMinGasPrice{}, proto.MessageName(&MsgGovUpdateMinGasPrice{}), nil)
cdc.RegisterConcrete(&MsgGovUpdateMinGasPrice{}, "umee/ugov/MsgGovUpdateMinGasPrice", nil)
cdc.RegisterConcrete(&MsgGovSetEmergencyGroup{}, "umee/ugov/MsgGovSetEmergencyGroup", nil)
cdc.RegisterConcrete(&MsgGovUpdateInflationParams{}, "umee/ugov/MsgGovUpdateInflationParams", nil)
}
Expand Down

0 comments on commit 41a826e

Please sign in to comment.