Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): unify and refactore client package #2256

Merged
merged 11 commits into from
Sep 21, 2023
Merged

feat(client): unify and refactore client package #2256

merged 11 commits into from
Sep 21, 2023

Conversation

robert-zaremba
Copy link
Member

Description

  • better fromAccount management
  • remove code duplication
  • msg checks
  • metoken queries in the umee/client
  • added logger to Tx and Query Client
  • use RPC queries rather than REST

@robert-zaremba robert-zaremba requested a review from a team as a code owner September 20, 2023 10:47
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #2256 (9fadd8a) into main (7f05ad4) will decrease coverage by 5.00%.
Report is 238 commits behind head on main.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
- Coverage   75.38%   70.39%   -5.00%     
==========================================
  Files         100      168      +68     
  Lines        8025    12649    +4624     
==========================================
+ Hits         6050     8904    +2854     
- Misses       1589     3146    +1557     
- Partials      386      599     +213
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
x/incentive/keeper/genesis.go 40.90% <ø> (ø)
x/incentive/keeper/grpc_query.go 59.18% <ø> (ø)
x/incentive/keeper/hooks.go 50.00% <ø> (ø)
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
... and 49 more

... and 87 files with indirect coverage changes

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2023
View reviewed changes
client/metoken.go Fixed Show fixed Hide fixed
gsk967
gsk967 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kosegor
kosegor approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@kosegor kosegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robert-zaremba robert-zaremba requested a review from a team as a code owner September 21, 2023 14:31
@robert-zaremba robert-zaremba added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 2ee13b9 Sep 21, 2023
24 of 25 checks passed
@robert-zaremba robert-zaremba deleted the robert/metoken-client branch September 21, 2023 20:41
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
@robert-zaremba @kosegor
feat(client): unify and refactore client package (#2256)
da24d25 
* add metoken client

* refactore tx client

* metoken queries

* add proto.Message validator

* use umee client in e2e tests

* nil check

* add QueryMetokenIndexPrices

* lint

* rollback change to 20s

* fix metoken e2e

---------

Co-authored-by: Egor Kostetskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosegor kosegor kosegor approved these changes

@gsk967 gsk967 gsk967 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @gsk967 @kosegor