Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go-1.21 #2261

Merged
merged 3 commits into from
Sep 22, 2023
Merged

chore: use go-1.21 #2261

merged 3 commits into from
Sep 22, 2023

Conversation

robert-zaremba
Copy link
Member

Description

@robert-zaremba robert-zaremba requested review from a team as code owners September 21, 2023 17:34
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2261 (ef6d2d5) into main (7f05ad4) will decrease coverage by 4.97%.
Report is 240 commits behind head on main.
The diff coverage is 84.18%.

❗ Current head ef6d2d5 differs from pull request most recent head 2ec7ea7. Consider uploading reports for the commit 2ec7ea7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   75.38%   70.42%   -4.97%     
==========================================
  Files         100      168      +68     
  Lines        8025    12643    +4618     
==========================================
+ Hits         6050     8904    +2854     
- Misses       1589     3140    +1551     
- Partials      386      599     +213     
Files Changed Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
cmd/ibc_denom/main.go 0.00% <0.00%> (ø)
util/coin/coin.go 12.50% <0.00%> (ø)
util/sdkutil/msg.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/bond.go 92.50% <ø> (ø)
x/incentive/keeper/genesis.go 40.90% <ø> (ø)
x/incentive/keeper/grpc_query.go 59.18% <ø> (ø)
x/incentive/keeper/hooks.go 50.00% <ø> (ø)
x/incentive/keeper/invariants.go 0.00% <ø> (ø)
... and 51 more

... and 85 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsk967
Copy link
Collaborator

gsk967 commented Sep 21, 2023

I have small suggestion can we do after the release of umee with cosmos-sdk 47

@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Sep 22, 2023
@robert-zaremba robert-zaremba added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 9c1f366 Sep 22, 2023
@robert-zaremba robert-zaremba deleted the robert/go-1.21 branch September 22, 2023 16:00
facundomedica pushed a commit that referenced this pull request Oct 30, 2023
* chore: use go-1.21

* go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants