fix: trivial e2e improvements #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
- Coverage 75.38% 70.48% -4.91%
==========================================
Files 100 170 +70
Lines 8025 12880 +4855
==========================================
+ Hits 6050 9079 +3029
- Misses 1589 3198 +1609
- Partials 386 603 +217
|
toteki
commented
Oct 9, 2023
Co-authored-by: kosegor <[email protected]>
|
|
||
| s.Require().Equal(uint64(5), params.HistoricStampPeriod) | ||
| s.Require().Equal(uint64(4), params.MaximumPriceStamps) | ||
| s.Require().Equal(uint64(20), params.MedianStampPeriod) |
There was a problem hiding this comment.
When this is repeated many time, then it would be better to use:
require := s.Require()
require.Equal(...)
There was a problem hiding this comment.
It could be - I merely moved this function between files without modifying it
facundomedica
pushed a commit
that referenced
this pull request
Oct 30, 2023
* delete eth dockerfiles * move gaia funcs to gaia.go * move metoken util out of setup folder; move oracle tests to oracle file * function comments * todo comments * comments * comments and combine some functions * price-feeder.go * import order * ibc.go * init balance as coins, not string * move vars around * comment * suggestion++ Co-authored-by: kosegor <[email protected]> --------- Co-authored-by: kosegor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything that doesn't need much review
This way the main PR is less cluttered