Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oracle)!: SetExchangeRateWithEvent #2320

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

Description

Event should always be emitted when prices are updated. We should enforce it by hiding not wanted API. In fact, the version without event was only used in tests.

@robert-zaremba robert-zaremba requested a review from a team as a code owner November 13, 2023 19:43
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2320 (a33e8e3) into main (7f05ad4) will decrease coverage by 4.89%.
Report is 284 commits behind head on main.
The diff coverage is 66.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
- Coverage   75.38%   70.50%   -4.89%     
==========================================
  Files         100      170      +70     
  Lines        8025    12876    +4851     
==========================================
+ Hits         6050     9078    +3028     
- Misses       1589     3195    +1606     
- Partials      386      603     +217     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
app/upgradev3/migrations.go 85.71% <ø> (+7.45%) ⬆️
util/coin/utoken.go 100.00% <100.00%> (ø)
util/ibc/ibc.go 58.82% <ø> (ø)
util/sdkutil/events.go 0.00% <ø> (ø)
x/incentive/client/tests/suite.go 100.00% <ø> (ø)
x/incentive/client/tests/tests.go 100.00% <ø> (ø)
... and 41 more

... and 100 files with indirect coverage changes

@robert-zaremba robert-zaremba added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 78c26a1 Nov 13, 2023
24 of 26 checks passed
@robert-zaremba robert-zaremba deleted the robert/oracle-api branch November 13, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants