Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the permission problem on goreleases #2333

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: fix the permission problem on goreleases #2333

merged 2 commits into from
Nov 21, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Nov 21, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Chores
    • Updated Docker commands to run containers as root to prevent permission issues.

@gsk967 gsk967 requested a review from a team as a code owner November 21, 2023 10:32
Copy link
Contributor

coderabbitai bot commented Nov 21, 2023

Walkthrough

The Makefile has been updated to modify Docker commands related to Protobuf Swagger generation and documentation updates. The key change is the inclusion of the --user root flag in docker run commands, which sets the user as root inside the container, likely to resolve permission issues encountered during container execution.

Changes

File(s) Change Summary
Makefile Added --user root to docker run commands for Protobuf Swagger operations.

🌟 In the code where dockers weave,
🐇 As root, we now believe.
With autumn's crisp cheer, we achieve,
🍂 Permissions fixed, no more to grieve!


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6f4b1f1 and b5a57e7.
Files selected for processing (1)
  • Makefile (2 hunks)

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@gsk967 gsk967 added the skip-e2e-test Skip the e2e tests label Nov 21, 2023
@gsk967
Copy link
Collaborator Author

gsk967 commented Nov 21, 2023

Check the release on my fork umee , It is working fine @robert-zaremba

@gsk967 gsk967 enabled auto-merge November 21, 2023 17:15
@gsk967 gsk967 added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 689ca36 Nov 21, 2023
20 checks passed
@gsk967 gsk967 deleted the sai/fix_releases branch November 21, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants