-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(oracle): update miss counter docs #2337
Conversation
WalkthroughThe recent updates address compatibility issues and operational improvements. A key compatibility fix involves the Umee Price Feeder with Cosmos SDK v0.47, requiring validators to upgrade to a newer version. Adjustments to the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- RELEASE_NOTES.md (1 hunks)
- x/oracle/README.md (2 hunks)
Additional comments: 4
RELEASE_NOTES.md (2)
32-32: The compatibility advisory is clear and actionable, ensuring validators are aware of the necessary upgrade to
umee/v2.3.0
or newer.34-34: The guidance provided for handling "out of gas" errors is practical and should help validators in troubleshooting and configuring their setups.
x/oracle/README.md (2)
51-53: The documentation clearly explains the new mechanism for handling exchange rates that do not meet the
VoteThreshold
. This change ensures that the old price and timestamp are retained if the votes for an exchange rate do not meet the required threshold.78-82: The updated documentation accurately reflects the new conditions for a validator miss, including the scenario where validators do not provide enough price votes for a given denomination. This change is important for validators to understand as it affects their performance evaluation and potential penalties.
Merge queue setting changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Sai Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- x/oracle/README.md (2 hunks)
Additional comments: 2
x/oracle/README.md (2)
51-53: The documentation clearly explains the new mechanism for updating exchange rates based on the total voting power. This change should help maintain the integrity of the exchange rates by ensuring they have sufficient validator support.
80-82: The documentation now includes a new condition for a "miss" in the voting process, where all validators receive a miss if the ballot denom support is less than the required
VoteThreshold
. This change should be carefully communicated to validators to ensure they understand the new criteria for missed votes.
Description
Oracle docs update: miss counter increase based on ballot support.
Summary by CodeRabbit
Documentation
umee/v2.3.0
or newer.gas_adjustment
to handle "out of gas" errors.libwasmvm
tov1.5.0
and the associated library file for binary installations.New Features