-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: git diff file matching for go mod/sum #2342
Conversation
WalkthroughThe recent updates across various GitHub workflow files introduce a new Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/workflows/govulncheck.yml (1 hunks)
- .github/workflows/simulations.yml (4 hunks)
- .github/workflows/tests.yml (4 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/govulncheck.yml
Additional comments: 8
.github/workflows/simulations.yml (4)
34-39: The addition of
FILES
underPATTERNS
to includego.mod
andgo.sum
is consistent with the summary and addresses the issue of build tests being skipped for changes in these files.59-64: The inclusion of
go.mod
andgo.sum
in theFILES
option ensures that simulations are triggered when there are changes to these files, which is crucial for dependency management.89-94: The changes made to the
test-app-after-import
job are in line with the pull request's goal to improve the CI/CD pipeline's responsiveness to changes in Go's module and sum files.118-123: The addition of
go.mod
andgo.sum
to theFILES
option in thetest-app-multi-seed-short
job is a necessary update to ensure that all changes are tested, maintaining the stability of the codebase..github/workflows/tests.yml (4)
45-51: The addition of the FILES option under the PATTERNS configuration is a good enhancement to ensure that changes to go.mod and go.sum files trigger the build workflow.
72-78: The FILES option under the PATTERNS configuration in the test-unit-cover job is correctly added to include go.mod and go.sum files in the unit test coverage checks.
104-110: The FILES option under the PATTERNS configuration in the test-e2e job is correctly added to ensure that end-to-end tests are run when there are changes to go.mod and go.sum files.
130-136: The FILES option under the PATTERNS configuration in the liveness-test job is correctly added to include go.mod and go.sum files in the liveness tests.
See actions like
https://github.com/umee-network/umee/actions/runs/7027225731/job/19121250001
Build tests are being skipped when only go.mod or go.sum are changed. This allows dependabot updates which cause build to fail to merge without warnings.
Summary by CodeRabbit