Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git diff file matching for go mod/sum #2342

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: git diff file matching for go mod/sum #2342

merged 1 commit into from
Nov 30, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Nov 30, 2023

See actions like

https://github.com/umee-network/umee/actions/runs/7027225731/job/19121250001

Build tests are being skipped when only go.mod or go.sum are changed. This allows dependabot updates which cause build to fail to merge without warnings.

Summary by CodeRabbit

  • Chores
    • Enhanced GitHub workflow configurations to include specific files for vulnerability checks and processing in automated jobs.

@toteki toteki requested a review from a team as a code owner November 30, 2023 17:11
Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Walkthrough

The recent updates across various GitHub workflow files introduce a new FILES configuration option under the PATTERNS section. This option allows for the inclusion of specific files, notably go.mod and go.sum, to be scanned for vulnerabilities or processed during job steps, enhancing the flexibility and scope of the workflows' actions.

Changes

File Path Change Summary
.github/workflows/govulncheck.yml Added FILES option under PATTERNS to include additional files for vulnerability checks.
.github/workflows/simulations.yml Included go.mod and go.sum in FILES option under PATTERNS.
.github/workflows/tests.yml Added FILES option specifying go.mod and go.sum under PATTERNS in multiple job configurations.

🐇✨
In workflows' land, amidst the code and clatter,
A new FILES option, to make security matter.
go.mod and sum, now under the scanner's gaze,
For safer deploys, the rabbit's code hops and plays. 🌟🚀


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c2985d3 and d3c768c.
Files selected for processing (3)
  • .github/workflows/govulncheck.yml (1 hunks)
  • .github/workflows/simulations.yml (4 hunks)
  • .github/workflows/tests.yml (4 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/govulncheck.yml
Additional comments: 8
.github/workflows/simulations.yml (4)
  • 34-39: The addition of FILES under PATTERNS to include go.mod and go.sum is consistent with the summary and addresses the issue of build tests being skipped for changes in these files.

  • 59-64: The inclusion of go.mod and go.sum in the FILES option ensures that simulations are triggered when there are changes to these files, which is crucial for dependency management.

  • 89-94: The changes made to the test-app-after-import job are in line with the pull request's goal to improve the CI/CD pipeline's responsiveness to changes in Go's module and sum files.

  • 118-123: The addition of go.mod and go.sum to the FILES option in the test-app-multi-seed-short job is a necessary update to ensure that all changes are tested, maintaining the stability of the codebase.

.github/workflows/tests.yml (4)
  • 45-51: The addition of the FILES option under the PATTERNS configuration is a good enhancement to ensure that changes to go.mod and go.sum files trigger the build workflow.

  • 72-78: The FILES option under the PATTERNS configuration in the test-unit-cover job is correctly added to include go.mod and go.sum files in the unit test coverage checks.

  • 104-110: The FILES option under the PATTERNS configuration in the test-e2e job is correctly added to ensure that end-to-end tests are run when there are changes to go.mod and go.sum files.

  • 130-136: The FILES option under the PATTERNS configuration in the liveness-test job is correctly added to include go.mod and go.sum files in the liveness tests.

@robert-zaremba robert-zaremba added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit b754f14 Nov 30, 2023
21 checks passed
@robert-zaremba robert-zaremba deleted the adam/ci branch November 30, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants