Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): refactore account management #2397

Closed
wants to merge 10 commits into from

Conversation

robert-zaremba
Copy link
Member

Description

  • GetTxResponse refactore

Copy link
Contributor

coderabbitai bot commented Jan 19, 2024

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: Patch coverage is 0.71429% with 278 lines in your changes are missing coverage. Please review.

Project coverage is 67.71%. Comparing base (7f05ad4) to head (8991045).
Report is 399 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
- Coverage   75.38%   67.71%   -7.68%     
==========================================
  Files         100      182      +82     
  Lines        8025    13498    +5473     
==========================================
+ Hits         6050     9140    +3090     
- Misses       1589     3753    +2164     
- Partials      386      605     +219     
Files Coverage Δ
sdkclient/bank.go 0.00% <ø> (ø)
sdkclient/key.go 0.00% <ø> (ø)
sdkclient/sign.go 0.00% <ø> (ø)
sdkclient/wasm.go 0.00% <ø> (ø)
sdkclient/auth.go 0.00% <0.00%> (ø)
sdkclient/gov.go 0.00% <0.00%> (ø)
sdkclient/client.go 1.50% <1.56%> (ø)

... and 141 files with indirect coverage changes

Comment on lines +75 to +81
for accKey, menomic := range mnemonics {
kr, err := CreateAccountFromMnemonic(c.keyringKeyring, accKey, menomic)
c.keyringRecord = append(c.keyringRecord, kr)
if err != nil {
return c, err
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
prop, err := c.GovProposal(propID)
assert.NoError(err)

now := time.Now()

Check warning

Code scanning / CodeQL

Calling the system time Warning test

Calling the system time may be a possible source of non-determinism
Copy link

stale bot commented Mar 10, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Mar 10, 2024
@stale stale bot closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant