-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(client): refactore account management #2397
Conversation
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 75.38% 67.71% -7.68%
==========================================
Files 100 182 +82
Lines 8025 13498 +5473
==========================================
+ Hits 6050 9140 +3090
- Misses 1589 3753 +2164
- Partials 386 605 +219
|
for accKey, menomic := range mnemonics { | ||
kr, err := CreateAccountFromMnemonic(c.keyringKeyring, accKey, menomic) | ||
c.keyringRecord = append(c.keyringRecord, kr) | ||
if err != nil { | ||
return c, err | ||
} | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description