chore(unification): rename KeeperBuilder to Builder #2471
Conversation
WalkthroughThe overall change across the codebase involves a significant renaming effort, transitioning from the use of Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
- Coverage 75.38% 69.38% -6.01%
==========================================
Files 100 185 +85
Lines 8025 10909 +2884
==========================================
+ Hits 6050 7569 +1519
- Misses 1589 2712 +1123
- Partials 386 628 +242
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (18)
- app/app.go (4 hunks)
- x/metoken/keeper/intest/keeper_test.go (1 hunks)
- x/metoken/keeper/intest/msg_server_test.go (4 hunks)
- x/metoken/keeper/keeper.go (1 hunks)
- x/metoken/keeper/unit_test.go (1 hunks)
- x/ugov/keeper/intest/keeper.go (1 hunks)
- x/ugov/keeper/keeper.go (1 hunks)
- x/uibc/module/module.go (1 hunks)
- x/uibc/quota/genesis.go (2 hunks)
- x/uibc/quota/grpc_query.go (1 hunks)
- x/uibc/quota/intest/suite_test.go (1 hunks)
- x/uibc/quota/keeper.go (2 hunks)
- x/uibc/quota/msg_server.go (1 hunks)
- x/uibc/quota/unit_test.go (1 hunks)
- x/uibc/uics20/ibc_module.go (1 hunks)
- x/uibc/uics20/ibc_module_test.go (1 hunks)
- x/uibc/uics20/ics4_wrapper.go (1 hunks)
- x/uibc/uics20/ics4_wrapper_test.go (1 hunks)
Additional comments: 28
x/ugov/keeper/intest/keeper.go (1)
- 23-23: The renaming from
NewKeeperBuildertoNewBuilderaligns with the PR's objective to unify naming conventions. Ensure that theNewBuilderfunction is correctly implemented in thekeeperpackage and that its usage here is consistent with its definition.x/ugov/keeper/keeper.go (1)
- 18-18: The introduction of the
NewBuilderfunction and theBuildertype aligns with the PR's objective to unify naming conventions. The implementation is correct and facilitates the construction of aKeeperinstance with the necessary dependencies.x/uibc/uics20/ics4_wrapper.go (2)
- 17-17: The change in the
ICS4struct fromquota.KeeperBuildertoquota.Builderaligns with the PR's objective to unify naming conventions. Ensure that thequota.Buildertype is correctly implemented and that its usage here is consistent with its definition.- 20-20: The update to the
NewICS4function signature to usequota.Builderis correctly implemented and aligns with the PR's objective. Ensure that thequota.Buildertype is correctly defined.x/metoken/keeper/unit_test.go (1)
- 25-25: The renaming from
NewKeeperBuildertoNewBuilderin theinitSimpleKeeperfunction aligns with the PR's objective to unify naming conventions. Ensure that theNewBuilderfunction is correctly implemented and that its usage here is consistent with its definition.x/uibc/quota/unit_test.go (1)
- 28-28: The renaming from
NewKeeperBuildertoNewBuilderin theinitKeeperfunction aligns with the PR's objective to unify naming conventions. Ensure that theNewBuilderfunction is correctly implemented and that its usage here is consistent with its definition.x/uibc/quota/keeper.go (2)
- 16-17: The introduction of the
Buildertype and theNewBuilderfunction aligns with the PR's objective to unify naming conventions. The implementation is correct and facilitates the construction of aKeeperinstance with the necessary dependencies.- 25-29: The
NewBuilderfunction is correctly implemented and aligns with the PR's objective. Ensure that theBuildertype is correctly defined and that its usage here is consistent with its definition.x/uibc/quota/msg_server.go (2)
- 14-14: Renaming
KeeperBuildertoBuilderin themsgServerstruct aligns with the PR's objective to standardize naming conventions across the codebase.- 18-18: The update in the
NewMsgServerImplfunction to acceptBuilderinstead ofKeeperBuilderis consistent with the renaming effort. However, it's noted that this line was not covered by tests.x/uibc/quota/grpc_query.go (2)
- 14-14: Renaming
KeeperBuildertoBuilderin theQuerierstruct aligns with the PR's objective to standardize naming conventions across the codebase.- 17-18: The update in the
NewQuerierfunction to acceptBuilderinstead ofKeeperBuilderis consistent with the renaming effort. However, it's noted that these lines were not covered by tests.Verification successful
The verification process has revealed that while there may not be direct tests specifically named to test the
NewQuerierfunction, the function is indeed used across various parts of the codebase, including in test setups. This indicates that theNewQuerierfunction is likely covered indirectly by tests that utilize these setups, such as insuite_test.goandgrpc_query_test.gofiles. Therefore, the concern about the lack of test coverage for theNewQuerierfunction following the renaming effort is addressed through its integration and usage in the system's overall testing framework.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify if NewQuerier function is covered by tests after renaming rg --type go "NewQuerier" --files-with-matches | xargs rg "func Test.*NewQuerier"Length of output: 81
Script:
#!/bin/bash # Search for any test files that reference the NewQuerier function to check for indirect testing rg --type go "NewQuerier" --files-with-matches | xargs rg --type go "func Test" # Additionally, verify the usage of the NewQuerier function in the codebase to understand its testing context better rg --type go "NewQuerier"Length of output: 2435
x/uibc/quota/intest/suite_test.go (1)
- 110-110: The change from
NewKeeperBuildertoNewBuilderin theinitKeeperfunction call is consistent with the PR's objective. This update is part of the test suite, ensuring that the renaming is also reflected in the tests.x/uibc/uics20/ics4_wrapper_test.go (1)
- 55-55: The change from
NewKeeperBuildertoNewBuilderin theTestSendPacketfunction call is consistent with the PR's objective. This update is part of the test suite, ensuring that the renaming is also reflected in the tests.x/uibc/module/module.go (2)
- 86-86: Renaming
KeeperBuildertoBuilderin theAppModulestruct aligns with the PR's objective to standardize naming conventions across the codebase.- 89-89: The update in the
NewAppModulefunction to acceptBuilderinstead ofKeeperBuilderis consistent with the renaming effort.x/uibc/uics20/ibc_module_test.go (1)
- 65-65: The change from
NewKeeperBuildertoNewBuilderin theTestIBCOnRecvPacketfunction call is consistent with the PR's objective. This update is part of the test suite, ensuring that the renaming is also reflected in the tests.x/metoken/keeper/intest/keeper_test.go (1)
- 57-57: The change from
NewKeeperBuildertoNewBuilderin theinitTestSuitefunction call is consistent with the PR's objective. This update is part of the test suite, ensuring that the renaming is also reflected in the tests.x/uibc/uics20/ibc_module.go (2)
- 27-27: Renaming
KeeperBuildertoBuilderin theICS20Modulestruct aligns with the PR's objective to standardize naming conventions across the codebase.- 34-34: The update in the
NewICS20Modulefunction to acceptBuilderinstead ofKeeperBuilderis consistent with the renaming effort.app/app.go (4)
- 284-284: The renaming of
UIbcQuotaKeeperBfromuibcquota.KeeperBuildertouibcquota.Builderaligns with the PR's objective to standardize naming conventions across the codebase. This change enhances readability and consistency.- 464-464: The use of
ugovkeeper.NewBuilderto instantiateUGovKeeperBfollows the PR's renaming convention and is correctly applied here. This change contributes to the overall goal of improving codebase consistency.- 497-497: Similarly, the instantiation of
MetokenKeeperBusingmetokenkeeper.NewBuilderadheres to the PR's renaming strategy. This consistent naming helps clarify the role of these components within the application.- 541-541: The renaming of
UIbcQuotaKeeperBto useuibcquota.NewBuilderin this context is consistent with the PR's objectives. It's good to see the renaming effort being applied thoroughly across the codebase.x/metoken/keeper/intest/msg_server_test.go (4)
- 610-610: The renaming from
KeeperBuildertoBuilderis consistent with the PR's objective and is correctly applied here.Ensure that the renaming does not inadvertently affect the functionality of the tests. It might be beneficial to verify that all tests still pass and behave as expected after the renaming.
- 707-707: The renaming from
KeeperBuildertoBuilderis correctly applied here as well.Similar to the previous comment, please ensure that the renaming does not affect the functionality of the tests.
- 1351-1351: Renaming applied correctly in the context of depegging tests.
As with the previous instances, verify that the functionality of the tests remains intact after the renaming.
- 1448-1448: The renaming from
KeeperBuildertoBuilderis applied correctly here as well.Please verify the functionality of the tests after the renaming.
Description
Small update to unify the name used in modules
Summary by CodeRabbit