chore(coin): update u/umee sample coin names

[robert-zaremba]

Description

Summary by CodeRabbit

• Refactor
  • Improved consistency and clarity in the naming of currency denominations within the system.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing clarity and consistency in variable naming related to Umee denominations across different parts of the codebase. Specifically, variables have been renamed for better readability, and the denomination symbol has been standardized to U_umee in tests related to rewards, bonds, unbondings, and incentive programs.

Changes

File Path	Change Summary
util/coin/fixtures.go	Renamed variables for consistency and clarity in Umee denominations.
x/incentive/.../genesis_test.go x/incentive/.../msgs_test.go	Updated denomination symbol to U_umee in tests for rewards and incentive programs.

🐇🌟
In the realm of code, where clarity is king,
A rabbit hopped through, making variables sing.
U_umee now reigns, in tests far and wide,
With consistency and clarity standing side by side.
So here's to the changes, may they be ever so bright,
Guiding the code, like stars in the night.
🌌🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 920b379 and 98a83c4.

Files selected for processing (3)

• util/coin/fixtures.go (2 hunks)
• x/incentive/genesis_test.go (12 hunks)
• x/incentive/msgs_test.go (1 hunks)

Additional comments (15)

util/coin/fixtures.go (2)

• 22-22: Renaming U_umee1 to align with the new naming convention is appropriate. However, the use of Utoken function here (and elsewhere) should be consistent in naming. Consider renaming Utoken and related functions to follow the same naming convention for clarity.

Consider renaming Utoken to UToken to maintain consistency in naming conventions across the codebase.

• 42-42: Re-enabling the var-naming lint rule is good practice after disabling it for specific sections. This ensures that the codebase adheres to the naming conventions and coding standards.

x/incentive/msgs_test.go (1)

• 23-23: Updating the denomination symbol in the uToken declaration to coin.U_umee aligns with the PR objectives for consistency and clarity in naming conventions. This change is correctly applied and should not impact the functionality of the tests, assuming the rest of the codebase has been updated accordingly.

x/incentive/genesis_test.go (12)

• 41-41: Renaming the UToken field in RewardTracker to use coin.U_umee is consistent with the PR objectives. This change enhances clarity and consistency in the codebase.
• 53-53: Similarly, updating the UToken field in RewardAccumulator to coin.U_umee aligns with the renaming effort and improves code readability.
• 61-61: The use of coin.U_umee in NewIncentiveProgram demonstrates consistency in applying the new naming convention across the incentive module's genesis state. This change is appropriate and enhances code clarity.
• 95-95: Updating the UToken field in Bond to sdk.NewInt64Coin(coin.U_umee, 1) is correctly done and aligns with the PR's objectives. This ensures consistency in the denomination symbol used throughout the codebase.
• 108-108: The change in AccountUnbondings to use coin.U_umee for the UToken field is consistent with the renaming effort and improves the clarity of the code.
• 119-119: The use of coin.U_umee in NewIncentiveProgram within the test for validating incentive programs is correctly applied and aligns with the renaming objectives.
• 133-133: The test case adjustment to use coin.New(coin.U_umee, 100) for invalidTotalRewards.TotalRewards is consistent with the renaming effort. However, it's important to ensure that the logic of the test remains valid and that the error expected is indeed due to the reasons outlined in the test case.

Ensure that the logic of the test case remains valid after the renaming and that the expected errors are due to the outlined reasons.

• 184-184: The creation of a valid Bond using coin.New(coin.U_umee, 1) in the test for validating structs is correctly done and aligns with the renaming objectives.
• 199-199: The creation of a valid RewardTracker using coin.U_umee in the test for validating structs is consistent with the renaming effort and enhances code clarity.
• 223-223: The creation of a valid RewardAccumulator using coin.U_umee in the test for validating structs aligns with the renaming objectives and improves code readability.
• 243-243: The creation of a valid Unbonding using coin.New(coin.U_umee, 1) in the test for validating structs is correctly done and aligns with the renaming objectives.
• 258-258: The creation of valid AccountUnbondings using coin.U_umee in the test for validating structs is consistent with the renaming effort and enhances code clarity.