feature(auction) genesis #2517

robert-zaremba · 2024-05-06T23:56:06Z

Description

coderabbitai · 2024-05-06T23:56:14Z

Walkthrough

The recent updates in the auction module focus on restructuring rewards, bids, and auctions for improved management. These changes introduce new data structures, validation checks, and updated functions to enhance the auction system's functionality and robustness in the blockchain environment.

Changes

Files	Change Summary
`proto/umee/auction/v1/genesis.proto`, `x/auction/keeper/rewards.go`	Restructured rewards entities, introduced `RewardsKV` and `BidKV` messages, updated key fields. Renamed and added functions for managing rewards bids and auctions.
`x/auction/genesis.go`, `x/auction/keeper/genesis.go`	Updated `DefaultGenesis`, `Validate`, `ExportGenesis`, and `InitGenesis` for new data handling.
`x/auction/keeper/grpc_query.go`	Enhanced `RewardsAuction` with comments on null values for `Bidder` and `Bid`.
`x/auction/module/module.go`	Modified `ExportGenesis` to handle errors, added `util` import.
`x/auction/keeper/genesis_test.go`, `x/auction/keeper/init_test.go`	Added test functions and structures for genesis state initialization and keeper testing.
`x/ugov/keeper/intest/keeper.go`, `x/uibc/quota/unit_test.go`	Updated codec initialization and imports for codec and types packages.

Poem

🐰💻✨
In the land of code and block,
Changes brew in the auction stock.
Bids and rewards, neatly arrayed,
With robust checks, the foundation's laid.
Hop and cheer, for updates are here,
A blockchain dance, the future is clear!
🎉🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9a0a5a9 and d9ab125.

Files ignored due to path filters (1)

x/auction/genesis.pb.go is excluded by !**/*.pb.go, !**/*.pb.go

Files selected for processing (6)

proto/umee/auction/v1/genesis.proto (2 hunks)
x/auction/genesis.go (1 hunks)
x/auction/keeper/genesis.go (1 hunks)
x/auction/keeper/grpc_query.go (1 hunks)
x/auction/keeper/rewards.go (2 hunks)
x/auction/module/module.go (2 hunks)

Additional Context Used

GitHub Check Runs (1)

Run golangci-lint failure (5)

x/auction/module/module.go: [failure] 136-136:
Error return value of (github.com/umee-network/umee/v6/x/auction/keeper.Keeper).InitGenesis is not checked (errcheck)

x/auction/module/module.go: [failure] 21-21:
File is not goimports-ed (goimports)

Additional comments not posted (14)

x/auction/keeper/genesis.go (2)

8-22: Changes in ExportGenesis function handle errors effectively and construct GenesisState correctly.

25-37: Changes in InitGenesis function handle errors effectively and manage rewards data correctly.

proto/umee/auction/v1/genesis.proto (3)

17-21: Addition of rewards_auctions and rewards_bids fields in GenesisState are correctly defined.

23-27: RewardsKV message is correctly defined with appropriate field types.

29-32: BidKV message is correctly defined with appropriate field types.

x/auction/genesis.go (2)

9-17: Initialization of GenesisState in DefaultGenesis function is correctly implemented.

21-41: Validation logic in Validate method of GenesisState is correctly implemented.

x/auction/keeper/grpc_query.go (1)

32-32: The added comment in RewardsAuction method clarifies the return values effectively.

x/auction/keeper/rewards.go (5)

49-49: Renaming of currentRewardsAuctionID function is consistent with the described changes.

102-114: Implementation of getAllRewardsBids function is correct and handles errors effectively.

117-125: Implementation of storeAllRewardsBids function is correct and handles errors effectively.

138-150: Implementation of getAllRewardsAuctions function is correct and handles errors effectively.

159-167: Implementation of storeAllRewardsAuctions function is correct and handles errors effectively.

x/auction/module/module.go (1)

20-20: Addition of the import statement for github.com/umee-network/umee/v6/util is necessary for the changes in ExportGenesis.

x/auction/module/module.go

gsk967

utACK,
Small suggestion , can you add

func nextRewardsID(currentId int) int {
...
}

x/auction/genesis.go

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d9ab125 and 743108e.

Files selected for processing (2)

x/auction/keeper/rewards.go (2 hunks)
x/auction/module/module.go (2 hunks)

Files skipped from review as they are similar to previous changes (2)

x/auction/keeper/rewards.go
x/auction/module/module.go

codecov · 2024-05-07T09:52:42Z

Codecov Report

Attention: Patch coverage is 49.38272% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 63.16%. Comparing base (7f05ad4) to head (d611e4a).
Report is 466 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2517       +/-   ##
===========================================
- Coverage   75.38%   63.16%   -12.23%     
===========================================
  Files         100      273      +173     
  Lines        8025    15782     +7757     
===========================================
+ Hits         6050     9968     +3918     
- Misses       1589     5042     +3453     
- Partials      386      772      +386

Files	Coverage Δ
x/auction/keeper/grpc_query.go	`0.00% <ø> (ø)`
x/ugov/keeper/intest/keeper.go	`100.00% <100.00%> (ø)`
x/auction/module/module.go	`67.30% <50.00%> (ø)`
x/auction/keeper/genesis.go	`54.54% <54.54%> (ø)`
x/auction/keeper/rewards.go	`27.27% <69.44%> (ø)`
x/auction/genesis.go	`0.00% <0.00%> (ø)`

... and 236 files with indirect coverage changes

coderabbitai

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 743108e and d611e4a.

Files selected for processing (4)

x/auction/keeper/genesis_test.go (1 hunks)
x/auction/keeper/init_test.go (1 hunks)
x/ugov/keeper/intest/keeper.go (2 hunks)
x/uibc/quota/unit_test.go (2 hunks)

Additional comments not posted (3)

x/ugov/keeper/intest/keeper.go (1)

17-17: LGTM! The initialization of ugov.Keeper appears clean and isolated, suitable for testing purposes.

x/auction/keeper/init_test.go (1)

17-26: LGTM! The initialization of Keeper for the auction module is well-structured for testing purposes.

x/uibc/quota/unit_test.go (1)

22-22: LGTM! The initialization of Keeper for the UIBC quota module is well-structured for testing purposes.

x/auction/keeper/genesis_test.go

feature(auction) genesis

d9ab125

robert-zaremba requested a review from a team as a code owner May 6, 2024 23:56

coderabbitai bot reviewed May 7, 2024

View reviewed changes

x/auction/module/module.go Show resolved Hide resolved

gsk967 approved these changes May 7, 2024

View reviewed changes

x/auction/genesis.go Show resolved Hide resolved

robert-zaremba added 2 commits May 7, 2024 11:46

lint

da480fd

remove tmp files

743108e

coderabbitai bot reviewed May 7, 2024

View reviewed changes

robert-zaremba added 4 commits May 7, 2024 15:42

test genesis

f5ca4a6

chore: use tsdk.NewCodec

e638e12

Merge branch 'main' into robert/auction-genesis

dba344f

tests

d611e4a

coderabbitai bot reviewed May 7, 2024

View reviewed changes

x/auction/keeper/genesis_test.go Show resolved Hide resolved

robert-zaremba merged commit c7385fd into main May 7, 2024
20 of 26 checks passed

robert-zaremba deleted the robert/auction-genesis branch May 7, 2024 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(auction) genesis #2517

feature(auction) genesis #2517

robert-zaremba commented May 6, 2024

coderabbitai bot commented May 6, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

gsk967 left a comment

coderabbitai bot left a comment

codecov bot commented May 7, 2024 •

edited

Loading

coderabbitai bot left a comment

feature(auction) genesis #2517

feature(auction) genesis #2517

Conversation

robert-zaremba commented May 6, 2024

Description

coderabbitai bot commented May 6, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

gsk967 left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented May 7, 2024 • edited Loading

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot commented May 6, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented May 7, 2024 •

edited

Loading