Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auction): add cli #2521

Merged
merged 2 commits into from
May 15, 2024
Merged

feat(auction): add cli #2521

merged 2 commits into from
May 15, 2024

Conversation

robert-zaremba
Copy link
Member

No description provided.

@robert-zaremba robert-zaremba requested a review from a team as a code owner May 14, 2024 22:05
@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label May 14, 2024
Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

The recent updates to the Umee repository involve enhancing the CLI capabilities for the x/auction module. Users can now efficiently query rewards parameters, check auction states, and place bids in rewards auctions. Import statements were adjusted in the x/auction and x/uibc modules to accommodate these new functionalities, improving the overall user experience.

Changes

File(s) Change Summary
.../auction/client/cli/query.go Introduced CLI query commands for the x/auction module, enabling users to query rewards parameters and auction state.
.../auction/client/cli/tx.go Added CLI transaction commands for placing bids in rewards auctions.
.../auction/module/module.go Updated to import cli and return commands from the cli package in GetTxCmd and GetQueryCmd.
.../uibc/client/cli/query.go Added import statement for github.com/umee-network/umee/v6/util/cli.
.../uibc/client/cli/tx.go Added import statement for github.com/umee-network/umee/v6/x/uibc.

🐇✨ In code's embrace, new commands arise,
To query and bid under auction skies.
With imports aligned and functions set,
The CLI's power, we won't forget.
As modules evolve and features expand,
We celebrate progress, hand in hand. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between efdb6d4 and d32e373.
Files selected for processing (5)
  • x/auction/client/cli/query.go (1 hunks)
  • x/auction/client/cli/tx.go (1 hunks)
  • x/auction/module/module.go (2 hunks)
  • x/uibc/client/cli/query.go (1 hunks)
  • x/uibc/client/cli/tx.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • x/uibc/client/cli/query.go
Additional comments not posted (6)
x/uibc/client/cli/tx.go (1)

8-8: Import statement added for the uibc module.

x/auction/client/cli/tx.go (1)

1-31: The GetTxCmd function is well-defined and follows best practices.

x/auction/client/cli/query.go (2)

1-32: The GetQueryCmd function is well-defined and follows best practices.


34-54: The RewardsParams function is well-defined and follows best practices.

x/auction/module/module.go (2)

84-84: The GetTxCmd function correctly returns the new CLI transaction commands.


89-89: The GetQueryCmd function correctly returns the new CLI query commands.

x/auction/client/cli/tx.go Outdated Show resolved Hide resolved
x/auction/client/cli/query.go Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 62.82%. Comparing base (7f05ad4) to head (411ae09).
Report is 471 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2521       +/-   ##
===========================================
- Coverage   75.38%   62.82%   -12.57%     
===========================================
  Files         100      275      +175     
  Lines        8025    15866     +7841     
===========================================
+ Hits         6050     9968     +3918     
- Misses       1589     5126     +3537     
- Partials      386      772      +386     
Files Coverage Δ
x/uibc/client/cli/query.go 35.52% <ø> (ø)
x/uibc/client/cli/tx.go 0.00% <ø> (ø)
x/auction/module/module.go 67.30% <0.00%> (ø)
x/auction/client/cli/tx.go 0.00% <0.00%> (ø)
x/auction/client/cli/query.go 0.00% <0.00%> (ø)

... and 235 files with indirect coverage changes

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d32e373 and 411ae09.
Files selected for processing (1)
  • x/auction/client/cli/tx.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • x/auction/client/cli/tx.go

@robert-zaremba robert-zaremba added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 3fdf9d3 May 15, 2024
20 of 25 checks passed
@robert-zaremba robert-zaremba deleted the robert/auction-cli branch May 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants