Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cosmos/ibc-go/v7 from 7.4.0 to 7.5.0 #2522

Merged
merged 7 commits into from
May 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2024

Bumps github.com/cosmos/ibc-go/v7 from 7.4.0 to 7.5.0.

Release notes

Sourced from github.com/cosmos/ibc-go/v7's releases.

v7.5.0

We present here a summary of the most relevant changes, please see the v7.5.0 changelog for the full set of changes included in this release.

dependencies

  • Cosmos SDK has been bumped to v0.47.11.
  • CometBFT has been bumped to v0.37.5.

apps/transfer

  • In v8.1.0 the field allowed_packet_data was added to the Allocation type used for authz support of IBC transfers. This field was originally a list of MsgTransfer's memo packet data keys that were allowed (i.e. top level JSON object keys). After receiving some feedback (thanks to Yieldmos team), we have re-purposed this field to be a list of full memo strings. That means that this field contains a list of memo strings that that the granter allows the grantee to include in the memo field of MsgTransfer, the grantee can then submit MsgTransfer with one of the allowed memo strings. See the documentation for more information.
  • In OnChanOpenTry, when the counterparty version does not match the executing chain's own version, instead of returning an error, the current version is now returned. This allows the channel handshake to complete in situations where the handshake initiating chain has the fee middleware wired up, but the counterparty doesn't (then transfer channel will be created with a version that does not contain fee middleware information). Similar change has been applied to OnChanOpenTry of the host submodule in 27-interchain-accounts. See PR cosmos/ibc-go#6253 for more details.

apps/27-interchain-accounts

Unordered channels

When ICA was initially released in v3.0.0 ICA channels were only allowed to be ordered, which causes the channel to close if a timeout occurs, forcing the user to reopen it. Support for unordered channels was introduced in v8.1.0, and with this release we have now back ported the feature to the v7 release line.

We have also changed the default ordering of new ICA channels from ordered to unordered. This means that new ICA channels will be unordered by default. Ordering can be specified either by setting the field ordering of MsgRegisterInterchainAccount or using the newly introduced function RegisterInterchainAccountWithOrdering (in case the legacy RegisterInterchainAccount function is used by a custom auth module).

Queries

We have added the message MsgModuleQuerySafe, which enables to perform queries on the host chain. This message contains a list of QueryRequests that will be routed to the query router when the message MsgModuleQuerySafe is executed on the host chain. The MsgModuleQuerySafe message can be included in the list of encoded sdk.Msgs of InterchainPacketData. The host chain will return on the acknowledgment the responses for all the queries (in the same order as the query requests in the Requests field of the MsgModuleQuerySafe).

Please note that only module safe queries can be executed (i.e. deterministic queries that are safe to be called from within the state machine). See the documentation for more details and the list of supported queries.

Please also note that it is mandatory to register the gRPC query router after the creation of the host submodule's keeper, otherwise nodes will not start. The WithQueryRouter function should be used. Please check the sample integration code in the documentation for more details.

This feature will also be included in the upcoming v8.3.0 release.

apps/29-fee

  • We have fixed a bug where, upon channel closure, already refunded fees remained in state in the event of one or more of the packet fees attached to a packet not being refunded. See PR cosmos/ibc-go#6255 for more details. Many thanks to @​sushiwushi for reporting this bug.

To learn more about ibc-go versioning, please read our RELEASES.md.

IMPORTANT: Please read the migration guides for any versions of ibc-go that you might be going through when upgrading to this version. For example: if you upgrade from the IBC module contained in the Cosmos SDK 0.42.0 to SDK v0.47.11 and ibc-go v7.5.0, please follow:

  1. The migration from SDK 0.41.x or 0.42.x to the IBC module in the ibc-go repository based on the SDK v0.44.x.
  2. The migration from ibc-go v1 to v2.
  3. The migration from ibc-go v2 to v3.
  4. The migration from ibc-go v3 to v4.
  5. The migration from ibc-go v4 to v5.
  6. The migration from ibc-go v5 to v6.
  7. The migration from ibc-go v6 to v7.
  8. The migration from ibc-go v7 to v7.1.
  9. The migration from ibc-go v7.2 to v7.3.
Changelog

Sourced from github.com/cosmos/ibc-go/v7's changelog.

v7.5.0 - 2024-05-14

Dependencies

  • #6254 Update Cosmos SDK to v0.47.11 and CometBFT to v0.37.5.

State Machine Breaking

  • (light-clients/07-tendermint) #6276 Fix: No-op to avoid panicking on UpdateState for invalid misbehaviour submissions.

Improvements

  • (apps/27-interchain-accounts) #6147 Emit an event signalling that the host submodule is disabled.
  • (testing) #6180 Add version to tm abci headers in ibctesting.
  • (apps/27-interchain-accounts, apps/tranfer, apps/29-fee) #6253 Allow channel handshake to succeed if fee middleware is wired up on one side, but not the other.
  • (apps/transfer) #6268 Use memo strings instead of JSON keys in AllowedPacketData of transfer authorization.

Features

  • (apps/27-interchain-accounts) #5633 Allow new ICA channels to use unordered ordering.
  • (apps/27-interchain-accounts) #5785 Introduce a new tx message that ICA host submodule can use to query the chain (only those marked with module_query_safe) and write the responses to the acknowledgement.

Bug Fixes

  • (apps/29-fee) #6255 Delete already refunded fees from state if some fee(s) cannot be refunded on channel closure.
Commits
  • 3a5f6d4 update changelog before v7.5.0 release
  • eff9b35 Update CHANGELOG.md
  • a98ebca imp: allow memo strings instead of keys for transfer authorizations (backport...
  • 1c05fa7 fix: noop on UpdateState for invalid misbehaviour (backport #6276) (#6296)
  • 2e7e3ea workaround for bank module safe queries (#6286)
  • a4ecd55 fix: delete already refunded fees from state if some fee cannot be refunded o...
  • 50a88fa feat(release/v7.5.x): use unordered ordering by default for new ica channels ...
  • 3ef2a97 imp(apps): allow one sided fee middleware handshakes to complete (backport #6...
  • fea2507 deps: bump sdk v0.47.11 (#6254)
  • 29dd2f3 imp: add version to tm headers in ibctesting (release/v7.5.x) (#6180)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner May 15, 2024 02:48
Copy link
Contributor

coderabbitai bot commented May 15, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Bumps [github.com/cosmos/ibc-go/v7](https://github.com/cosmos/ibc-go) from 7.4.0 to 7.5.0.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v7.5.0/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v7.4.0...v7.5.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cosmos/ibc-go/v7-7.5.0 branch from 44a43df to 2c7bca3 Compare May 15, 2024 09:24
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.78%. Comparing base (7f05ad4) to head (73428bc).
Report is 477 commits behind head on main.

❗ Current head 73428bc differs from pull request most recent head ed21de1. Consider uploading reports for the commit ed21de1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2522       +/-   ##
===========================================
- Coverage   75.38%   62.78%   -12.61%     
===========================================
  Files         100      275      +175     
  Lines        8025    15890     +7865     
===========================================
+ Hits         6050     9976     +3926     
- Misses       1589     5141     +3552     
- Partials      386      773      +387     
Files Coverage Δ
app/app.go 92.84% <100.00%> (ø)
sdkclient/query/client.go 0.00% <0.00%> (ø)

... and 235 files with indirect coverage changes

@gsk967 gsk967 enabled auto-merge May 16, 2024 11:54
@gsk967 gsk967 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 94a34f5 May 16, 2024
19 of 24 checks passed
@gsk967 gsk967 deleted the dependabot/go_modules/github.com/cosmos/ibc-go/v7-7.5.0 branch May 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants