Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the account summary grpc #2528

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: fix the account summary grpc #2528

merged 1 commit into from
May 23, 2024

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented May 17, 2024

Description

We miss the account summary when user collateralize the uTokens


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner May 17, 2024 13:34
Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

The AccountSummaries function in the accounts_summary.go file has been streamlined by eliminating a condition check related to UToken balances. This simplification allows for a more direct and efficient retrieval of account summaries. Additionally, an unused import from github.com/umee-network/umee/v6/util/coin has been removed.

Changes

File Path Change Summary
x/leverage/keeper/accounts_summary.go Simplified logic in AccountSummaries function by removing a specific condition check.
.../umee/v6/util/coin Removed unused import.

In code, we find a simpler way,
With checks and balances cast away.
A rabbit hops through lines so neat,
To make the summaries complete.
🎩🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gsk967 gsk967 added the skip-e2e-test Skip the e2e tests label May 17, 2024
@gsk967 gsk967 enabled auto-merge May 17, 2024 13:34
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (1)
x/leverage/keeper/accounts_summary.go (1)

Line range hint 14-19: Consider adding detailed comments explaining the price calculation logic.

This will enhance maintainability and understandability, especially for new developers or when revisiting this code after some time.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 84f3562 and eb898a1.
Files selected for processing (1)
  • x/leverage/keeper/accounts_summary.go (2 hunks)
Additional comments not posted (1)
x/leverage/keeper/accounts_summary.go (1)

Line range hint 140-150: The input validation and error handling in this function are correctly implemented.

Good job on ensuring robustness against invalid inputs.

x/leverage/keeper/accounts_summary.go Show resolved Hide resolved
@gsk967 gsk967 added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 1eb2038 May 23, 2024
20 of 35 checks passed
@gsk967 gsk967 deleted the sai/fix_accounts_summary branch May 23, 2024 11:37
@coderabbitai coderabbitai bot mentioned this pull request Dec 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants