implement view property glassIconColor to override the icons default color
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelknoch
changed the title
glassIconColor to override the icons default color
|
hello @iRoachie ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently saw issues with the icon color in the search bar when using a device on ios 13 in dark mode. In our case the issue seems to be caused by overriding the
textFieldBackgroundColorto white, which does not match the ios dark mode theming but it's a requirement of our app designs.I think if there is an api to override the backgroundColor, than it makes sense to have an api to override the icon color as well. @umhan35 @iRoachie