Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use temporarily serverless@^3 instead of v4 which require login #249

Merged
merged 1 commit into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
aws-region: ${{ env.AWS_REGION }}
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
- name: Install serverless
run: npm install -g serverless
run: npm install -g serverless@^3
- name: Note docker image digest
id: docker-image-digest
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
aws-region: ${{ env.AWS_REGION }}
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
- name: Install Serverless Framework
run: npm install -g serverless
run: npm install -g serverless@^3
- name: Wait for CloudFormation stack to be updated
run: aws cloudformation wait stack-update-complete --stack-name="docker-selenium-lambda-prod" || true
- name: Deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/demo-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
- name: Demo README's instructions
run: |
npm install -g serverless
npm install -g serverless@^3
sls create --template-url "https://github.com/umihico/docker-selenium-lambda/tree/main" --path docker-selenium-lambda && cd $_
sls deploy
sls invoke --function demo |& tee /tmp/scraping-result.txt
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ This image goes with these versions. [These are automatically updated and tested
## Running the demo

```bash
$ npm install -g serverless # skip this line if you have already installed Serverless Framework
$ npm install -g serverless@^3 # skip this line if you have already installed Serverless Framework
$ export AWS_REGION=ap-northeast-1 # You can specify region or skip this line. us-east-1 will be used by default.
$ sls create --template-url "https://github.com/umihico/docker-selenium-lambda/tree/main" --path docker-selenium-lambda && cd $_
$ sls deploy
Expand Down