fix: hmr failed when add missing dep after watch started #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormslowly
reviewed
Jan 7, 2024
| pub fn clear_resolver_cache(resolvers: &Resolvers) { | ||
| resolvers | ||
| .iter() | ||
| .for_each(|(_, resolver)| resolver.clear_entries()); |
There was a problem hiding this comment.
没有更小颗粒的 api。本来是想给 nodejs_resolver pr 一个方法，单独删一个 entry，但是内部缓存用的 key 值是经过处理后的 path，不是传入的 request。看了下，hmr，只有在加文件的时候需要重新 resolve 添加的这个文件，所以删缓存理论上对后续hmr的速度影响也可控。给 nodejs_resolver 提了个 issue：web-infra-dev/nodejs_resolver#201 ，如果后续有方法，这里再优化一下
sorrycc
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：watch 启动后，如果有缺少的 dep，增加此 dep，resolver 会因为缓存导致 resolve 不到 dep
解法：增加文件，在重新 resolve 前删除缓存