Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply PR 945 && fix hmr #953

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Reapply PR 945 && fix hmr #953

merged 2 commits into from
Mar 18, 2024

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Mar 14, 2024

  1. Reapply https://github.com/umijs/mako/pull/945。 该 pr 中将 compiler generate 直接运行中 rayon 线程池中,在 mako build --watch 时,generate 会产生一些异步任务,需要一个 tokio runtime 才能跑起来。 yuyanAssets 测试 hmr 已无问题;
  2. std::sync::OnceLock 替代 lazy_static, 因为 lazy_static 即将废弃,Officially deprecate lazy_static rust-lang-nursery/lazy-static.rs#214

@xusd320 xusd320 requested a review from sorrycc March 14, 2024 11:13
@xusd320 xusd320 changed the title Reapply PR 945 & fix hmr Reapply PR 945 && fix hmr Mar 14, 2024
@xusd320 xusd320 merged commit 506a462 into master Mar 18, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/e2e-hmr branch March 18, 2024 01:44
@stormslowly stormslowly restored the fix/e2e-hmr branch March 25, 2024 05:24
@stormslowly stormslowly deleted the fix/e2e-hmr branch August 9, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants