Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 兼容一下部分库的浏览器入口配置 #12421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SANmq
Copy link
Contributor

@SANmq SANmq commented May 27, 2024

具体表现为qrcode这种node环境和浏览器环境不同代码的,且在package.json中配置了browser的库。升级项目采用mfsu时遇到打包依赖报错,入口选择node版本的。也希望官方给出更好的方案,遇到问题的库时 [email protected]

Summary by CodeRabbit

  • 新功能
    • 增加了对某些库(如 qrcode)的兼容性,这些库在其 package.json 中配置了 browser 入口点。

具体表现为qrcode这种node环境和浏览器环境不同代码的,且在package.json中配置了browser的库。升级项目采用mfsu时遇到打包依赖报错,入口选择node版本的
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 2:29pm

Copy link

coderabbitai bot commented May 27, 2024

Walkthrough

此次修改主要是增强了对某些库(如 qrcode)的地址解析兼容性,这些库在其 package.json 文件中配置了 browser 入口点。具体实现是通过在 resolveUtils.ts 文件中的 browserResolver 中添加 aliasFields: ["browser"] 来实现的。

Changes

文件路径 变更摘要
packages/mfsu/src/utils/resolveUtils.ts browserResolver 中添加了 aliasFields: ["browser"] 以支持解析带有 browser 入口点的库

代码改动如春风,
解析兼容更从容。
aliasFields 新添处,
库中路径不迷蒙。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
packages/mfsu/src/utils/resolveUtils.ts (1)

Line range hint 52-52: 请避免使用 any 类型,这可能会导致类型安全问题。建议指定一个更精确的错误类型,例如 Error

- let lastError: any = null;
+ let lastError: Error | null = null;
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f6abd77 and 741afb9.
Files selected for processing (1)
  • packages/mfsu/src/utils/resolveUtils.ts (1 hunks)
Additional Context Used
Biome (1)
packages/mfsu/src/utils/resolveUtils.ts (1)

52-52: Unexpected any. Specify a different type.

Additional comments not posted (1)
packages/mfsu/src/utils/resolveUtils.ts (1)

16-16: 添加 aliasFields: ["browser"] 是为了解决特定库(如 qrcode)在其 package.json 中指定浏览器入口的兼容性问题。建议在此行上方添加更详细的注释,说明此配置的具体作用和影响。

@fz6m
Copy link
Contributor

fz6m commented May 27, 2024

感觉不是 resolve 配置的问题,我新创建一个 umi 项目,安装 qrcode ,然后按照官方 readme 里的 demo 使用是正常运行的。

@SANmq
Copy link
Contributor Author

SANmq commented May 28, 2024

感觉不是 resolve 配置的问题,我新创建一个 umi 项目,安装 qrcode ,然后按照官方 readme 里的 demo 使用是正常运行的。

你试试官方给的测试用例,examples/mfsu-independent这个项目,你下个qrcode试试看,我试了一下dev报错
image

@SANmq
Copy link
Contributor Author

SANmq commented May 28, 2024

关于resolveUtils.test.ts里的测试用例我看过了,没有{ "name": "qrcode", "version": "1.5.3", "main": "./lib/index.js", "browser": { "./lib/index.js": "./lib/browser.js", "fs": false } }的例子。即browser是一个对象的例子,至于umi项目为啥没这个问题我没有尝试过,umi项目使用的时候用的是eager策略,这个我不清楚能不能用在我们那个项目上,试了一下配置了eager运行会报错。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants