Skip to content

Commit

Permalink
Update security group configuration with lifecycle and revoke (#2)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcincuber authored May 21, 2020
1 parent 13455ae commit 37f5cf1
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v2.5.0
rev: v3.1.0
hooks:
- id: check-added-large-files
args: ['--maxkb=500']
Expand Down
18 changes: 15 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,30 @@ All notable changes to this project will be documented in this file.
<a name="unreleased"></a>
## [Unreleased]

- address comments format and use of tags in example
- add changes to support additional tags for cluster and cluster instance


<a name="1.1.0"></a>
## [1.1.0] - 2020-05-04

- add changes to support additional tags for cluster and cluster instance ([#1](https://github.com/umotif-public/terraform-aws-rds-aurora/issues/1))
- update CHANGELOG
- update config for chglog
- Add changelog


<a name="1.0.1"></a>
## [1.0.1] - 2020-04-21

- Add changelog


<a name="1.0.0"></a>
## 1.0.0 - 2020-04-20

- Add full module configuration with example for aurora mysql
- Initial commit


[Unreleased]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.0.0...HEAD
[Unreleased]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.1.0...HEAD
[1.1.0]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.0.1...1.1.0
[1.0.1]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/1.0.0...1.0.1
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Terraform 0.12. Pin module version to `~> v1.0`. Submit pull-requests to `master
```hcl
module "rds-aurora-mysql" {
source = "umotif-public/rds-aurora/aws"
version = "~> 1.0.0"
version = "~> 1.2.0"
name_prefix = "example-aurora-mysql"
engine = "aurora-mysql"
Expand Down
6 changes: 6 additions & 0 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ resource "aws_security_group" "main" {
Name = "${var.name_prefix}-sg"
}
)

revoke_rules_on_delete = true

lifecycle {
create_before_destroy = true
}
}

resource "aws_security_group_rule" "main_egress" {
Expand Down

0 comments on commit 37f5cf1

Please sign in to comment.