add slog and json log option #194
Conversation
| @@ -118,6 +118,8 @@ type options struct { | |||
| Dry bool `long:"dry" env:"DRY" description:"dry mode, no bans"` | |||
| Dbg bool `long:"dbg" env:"DEBUG" description:"debug mode"` | |||
| TGDbg bool `long:"tg-dbg" env:"TG_DEBUG" description:"telegram debug mode"` | |||
|
|
|||
| LoggingFormat string `long:"logging-format" env:"LOGGING_FORMAT" default:"text" description:"logging format, 'json' or 'text'"` | |||
There was a problem hiding this comment.
This should be added to the README, probably to the list of parameters. It may also be worth mentioning in the detailed explanation of the parameters as well.
There was a problem hiding this comment.
fixed, but my formatter did some changes in the readme, I hope you don't mind, they do not look destructive to me
app/main.go
Outdated
| } | ||
| logOpts = append(logOpts, lgr.Map(colorizer)) | ||
| var logger *slog.Logger | ||
| if loggingFormat == "json" { |
There was a problem hiding this comment.
My brain is going to explode by those nested else/ifs ;) It would be nice to simplify it and make it as plain as possible. Maybe a top-level switch with an early exit will help.
There was a problem hiding this comment.
I have not checked all the places where you replaced logging, but it seems to be a technical search/replace type of thing. Hopefully, you tried to run it and found no issues.
just a couple of minor things, nothing major. Also, please rebase with the current master, as it has a new PR merged in with some logging changes as well.
as we discussed, i tried to change standard log to structured logging.
So added flag
--logging-formatExample:
--logging-format=jsonwhich is default has
textvalue, so the default format of logs mostly was not changed.You also asked to "be careful" so I mostly save the DEBUG LEVEL format of messages by using fmt.
All other logs levels should be "native" for the SLOG format.