119 bug incorrect position calculation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulation results
|
Simulation results
|
samuelkuehnel
requested review from
robertik10
and removed request for
MaxJa4
robertik10
reviewed
Dec 1, 2023
| x, y, z = geodetic_to_ecef(lat, lon, h) | ||
| return ecef_to_enu(x, y, z, lat_ref, lon_ref, h_ref) | ||
| # Is not necessary in new version | ||
| # y *= -1 |
There was a problem hiding this comment.
# alt + 331.00000 is needed, because the altitude of the map itself has to be accounted for
# TODO: maybe can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the transformation from (lat,lon)-coordinates was fixed. The calculated and real values now match.
The new calculation was copied from pylot
Fixes #119
Type of change
Does this PR introduce a breaking change?
no
Most important changes
Updated Calculation method in
coordinate_transformation.pyReference values are now read from the Carla OpenDrive-Map
Class GeoRef removed as not needed anymore
Checklist: