Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

176: Expand dev launch with configurable vehicle-spawn + fixed spectator #178

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Jan 28, 2024

Description

Adds a node which is started by dev.launch. It spawns a configurable amount of vehicles and either teleports the spectator to the hero once or snaps him to the vehicle continuously. Also, vehicle lane changing of NPCs can be disabled/enabled. Spawned vehicles can be restricted to only cars (4 wheels).
Also, the simulation performance (Spectator window) is significantly faster now, as well as the RVIZ camera output (YMMV).

Fixes #176

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@MaxJa4 MaxJa4 added the enhancement New feature or request label Jan 28, 2024
@MaxJa4 MaxJa4 self-assigned this Jan 28, 2024
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvements, really helpful for testing. Maybe deacifvate dev launch in docker compose before merge.

Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvements, really helpful for testing. Maybe deacifvate dev launch in docker compose before merge.

Copy link

Simulation results

Metric Value
Avg. driving score 0.011422
Avg. route completion 5.97
Avg. infraction penalty 0.002198
Collisions with pedestrians 0.0
Collisions with vehicles 19.732
Collisions with layout 3.289
Red lights infractions 1.096
Stop sign infractions 0.0
Off-road infractions 0.098
Route deviations 0.0
Route timeouts 1.096
Agent blocked 1.096
Yield emergency vehicles infractions 0.0
Scenario timeouts 3.289
Min speed infractions 0.0

@MaxJa4 MaxJa4 merged commit 29a2530 into main Jan 30, 2024
3 checks passed
@MaxJa4 MaxJa4 deleted the 176-feat-test-route branch January 30, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Create Test-Route/-Scenario with Dev-Launch incl. vehicles + 1st person spectator
2 participants