Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update motion_planning.py #181

Closed
wants to merge 1 commit into from
Closed

Update motion_planning.py #181

wants to merge 1 commit into from

Conversation

robertik10
Copy link
Collaborator

@robertik10 robertik10 commented Jan 29, 2024

Description

As @samuelkuehnel thought, this line in the main branch might have lead to the Pipeline crashing since it doesnt have the emergency brake fix installed yet. Maybe changing this back will fix the problem until the emergency brake fix is on the main

Fixes # Pipeline crash

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Does this PR introduce a breaking change?

No

Most important changes

Which files functionalities are most important in this PR. On which part should the reviewer be focused on?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

this line in the main branch might have lead to the Pipeline crashing since it doesnt have the emergency brake fix installed yet.
Maybe chaning this back will fix the problem until the emergency brake fix is on the main
@robertik10 robertik10 added the bug Something isn't working label Jan 29, 2024
@robertik10 robertik10 self-assigned this Jan 29, 2024
@robertik10 robertik10 closed this Jan 29, 2024
@samuelkuehnel samuelkuehnel deleted the robertik10-patch-1 branch January 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant