Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanUp and Overhaul of Acting ; Final Steering #207

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

hellschwalex
Copy link
Collaborator

Description

  • Finalized Steering to only use the well-working and now extended PurePursuit Controller.
  • New Folder OBSOLETE with old, no longer needed Components, drastically simplifying Acting.
  • Overhauled Code to be more readable, Comments etc.

Fixes #168 #167 #52 #206 (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does this PR introduce a breaking change?

Stanley Controller is no longer used, PurePursuit drastically improved to now be useable at all speeds (tested to 20m/s)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@hellschwalex hellschwalex self-assigned this Mar 9, 2024
@hellschwalex hellschwalex linked an issue Mar 9, 2024 that may be closed by this pull request
7 tasks
Copy link

Simulation results

Metric Value
Avg. driving score 0.119232
Avg. route completion 0.34
Avg. infraction penalty 0.328024
Collisions with pedestrians 0.0
Collisions with vehicles 20.684
Collisions with layout 62.053
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.003
Route deviations 0.0
Route timeouts 20.684
Agent blocked 20.684
Yield emergency vehicles infractions 0.0
Scenario timeouts 20.684
Min speed infractions 0.0

Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes, thanks for removing the ACC and adjusting the steering

@samuelkuehnel samuelkuehnel merged commit 0fab952 into main Mar 12, 2024
3 checks passed
@samuelkuehnel samuelkuehnel deleted the 167-feature-stanley-controller-overhaul branch March 12, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants