Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

210 feature integrate new traffic light features #223

Merged
merged 5 commits into from
Mar 22, 2024
Merged

210 feature integrate new traffic light features #223

merged 5 commits into from
Mar 22, 2024

Conversation

JuliusMiller
Copy link
Collaborator

Description

Adds the feature to stop at a traffic light that is too close for the ego vehicle to see
Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

No

Most important changes

Changes in intersection behavior and in motion planning

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@JuliusMiller JuliusMiller self-assigned this Mar 19, 2024
@JuliusMiller JuliusMiller linked an issue Mar 19, 2024 that may be closed by this pull request
[Feature]: Integrate new traffic light features #210
Closed
@github-actions GitHub Actions
Copy link

Simulation results

Metric Value
Avg. driving score 0.0735
Avg. route completion 0.105
Avg. infraction penalty 0.7
Collisions with pedestrians 0.0
Collisions with vehicles 0.0
Collisions with layout 0.0
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0
Route deviations 0.0
Route timeouts 118.142
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 118.142
Min speed infractions 0.0

samuelkuehnel
samuelkuehnel approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samuelkuehnel samuelkuehnel merged commit bfbce49 into main Mar 22, 2024
2 checks passed
@github-actions GitHub Actions
Copy link

Simulation results

Metric Value
Avg. driving score 0.012705
Avg. route completion 37.305
Avg. infraction penalty 0.001298
Collisions with pedestrians 0.85
Collisions with vehicles 7.48
Collisions with layout 4.08
Red lights infractions 0.17
Stop sign infractions 0.17
Off-road infractions 0.124
Route deviations 0.0
Route timeouts 0.0
Agent blocked 0.34
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.17
Min speed infractions 0.0

@JuliusMiller JuliusMiller deleted the 210-feature-integrate-new-traffic-light-features branch April 1, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkuehnel samuelkuehnel samuelkuehnel approved these changes

Assignees

@JuliusMiller JuliusMiller

Labels
planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Integrate new traffic light features
2 participants
@JuliusMiller @samuelkuehnel