-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Charmes #208
base: master
Are you sure you want to change the base?
Adding Charmes #208
Conversation
I used the test image from: http://www.makeuseof.com/tag/instagram-filters-work-can-tell-difference/
I was looking at the wrong comparison image initially
Hey! Do you ming getting this branch up to date today? You can go |
# Conflicts: # site/css/cssgram.min.css # site/css/demo-site.css # site/css/demo-site.min.css # source/css/cssgram.css # source/css/cssgram.min.css # source/scss/cssgram.scss
I think I took care of it all, let me know if I missed something. |
I think this might benefit from a little more warmth in the highlight and violet in the shadow. What do you think? Also, do you mind committing only the updated scss and data files? (ignoring the built CSS) |
I can tweak it a bit tomorrow. It's kinda hard to tell from the sample image but I see where you're coming from. In the future I'll ignore the built CSS. |
I'm a little worried the image as a whole might be too violet now. I'm having trouble deciding since I think it looks fine when I move a little further away from my monitor; I figured I'd let someone else take a look at it. |
Here is the code I tried:
|
Tweaks
I think what you used is good but it looks too dark with the example I was using. The left is the original and the right is with the Instagram Charmes filter: http://imgur.com/a/QzavO. I took what you had and went ahead and upped the brightness and contrast a bit. This fixed the example I was using and didn't noticeably change the images you posted. |
Awesome, do you mind resolving the merge conflicts? A way to mitigate them is to only submit the Heres an example: #210 |
I had forgotten to branch for my initial README pull request. I would assume this should be able to be merged after my first pull request, but if not I can redo it. I tried to emulate the example image from here.