Added Juno filter #209
Added Juno filter #209
Conversation
|
What do you think of the recommended changes? It also seems #218 pulls in your Juno files from here |
|
Hey! :) Sorry for any inconvenience, git newbie here! |
| @extend %filter-base; | ||
| filter: contrast(1.2) saturate(0.8) $filters; | ||
| &:before { | ||
| background: linear-gradient(to bottom,rgba(255,255,255,0.2), rgba(74, 195, 111, 0.2), transparent); |
There was a problem hiding this comment.
Hey Thanks for the PR! This is looking great. I don't think you need a "green" in this gradient, and might use a gray instead such as linear-gradient(top,rgba(255,255,255,.2),rgba(156, 156, 156, 0.2),transparent);
| @mixin juno($filters...) { | ||
| @extend %filter-base; | ||
| filter: contrast(1.2) saturate(0.8) $filters; | ||
| &:before { |
There was a problem hiding this comment.
can you add a space between this line and the one before it and use a double :: for the pseudo element? 😄
|
Sorry were you seeing those comment sup there? The new review feature is a bit confusing, not sure if they sent |
#125
😄
Please, let me know if the filter is okay or if it needs some improvement! :)