Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readded Stinson filter #250

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Readded Stinson filter #250

wants to merge 3 commits into from

Conversation

rchung95
Copy link

stinson

@una
Copy link
Owner

una commented Nov 2, 2016 •
edited
Loading

Thanks for the PR! For some reason, this look a bit different on my system than on yours

screen shot 2016-11-02 at 10 04 29 am

@rchung95
Copy link
Author

rchung95 commented Nov 2, 2016

I retested it and notice that. I do apologize for not noticing it sooner. I have added another commit, and ran the test. I have changed the settings and this one is a lot better.

una
una reviewed Nov 3, 2016
View reviewed changes
source/scss/stinson.scss
// }
@mixin stinson($filters...) {
@include filter-base;
filter: brightness(1.25) contrast(0.8) saturate(0.95) grayscale(0.05) sepia(0.05) $filters;
Copy link
Owner

@una una Nov 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I did some adjustments, what do you think of using filter: brightness(1.15) contrast(.8) saturate(.85) sepia(.1);

and altering the ::after pseudo element to be:

background: rgba(240, 149, 128, .2);
mix-blend-mode: soft-light;

Before:
screen shot 2016-11-02 at 11 05 04 pm

After -- I think it looks a little bit closer (tiny bit lighter and warmer):
screen shot 2016-11-02 at 11 05 37 pm

@una
Copy link
Owner

una commented Nov 3, 2016

I made similar comments on #251 -- there are a few PRs on this filter right now, just waiting on the first one to adjust their filter

@una una mentioned this pull request Nov 3, 2016
Closed
@rchung95
Copy link
Author

rchung95 commented Nov 3, 2016

Added the requested changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@una una una left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchung95 @una