FIX (1.3): Better maintenance of state for the save draft + publish buttons #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… situations" This reverts commit 245caaf.
…utton in case draft isn't consistent with live version (ALSO the case if "record is deleted from stage", i.e. draft doesn't exist)
patricknelson
changed the title
patricknelson
changed the title
|
Bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses to important issues I've identified:
Granted #2 is just a revert of another commit (245caaf), however, this functionality is entirely consistent with other
Version'ed objects, i.e.SiteTree. I acknowledge that maintaining this functionality (i.e. button state updating if the form is modified in any way), however I believe that should be classified as a separate bug that should instead be addressed insilverstripe-cms, given it is more broad and consistency and, more importantly, visual feedback on current state is more valuable (in my subjective opinion).