Skip to content

Feature/scraping strategy - refactor: Remove WebScrapingStrategy and fix metadata extraction (#995) #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Feature/scraping strategy - refactor: Remove WebScrapingStrategy and fix metadata extraction (#995) #1161

wants to merge 2 commits into from

Conversation

ntohidi
Copy link
Collaborator

@ntohidi ntohidi commented May 28, 2025

Summary

This PR refactors the content scraping strategy by removing the BeautifulSoup-based WebScrapingStrategy class and making LXMLWebScrapingStrategy the sole implementation. This simplifies the codebase by eliminating duplicate functionality while maintaining all existing features with better performance.
Additionally, this PR fixes the metadata extraction issue where titles and other metadata were returning as null for certain websites. Fixes #995

List of files changed and why

  • content_scraping_strategy.py - Removed WebScrapingStrategy class, made LXMLWebScrapingStrategy inherit directly from ContentScrapingStrategy, added missing methods previously inherited
  • async_configs.py - Updated default scraping strategy from WebScrapingStrategy() to LXMLWebScrapingStrategy(), updated imports
  • types.py - Updated type definitions to remove WebScrapingStrategy references
  • utils.py - Improve title extraction with fallbacks for edge cases
  • init.py files - Updated public API exports to remove WebScrapingStrategy
  • docs/examples/scraping_strategies_performance.py - Update the test and make it compatible with the new change
  • tests/async/test_content_scraper_strategy.py - Update the test and make it compatible with the new change
  • tests/async/test_evaluation_scraping_methods_performance.configs.py - Update the test and make it compatible with the new change

How Has This Been Tested?

  • Verified that LXMLWebScrapingStrategy maintains all functionality of the removed WebScrapingStrategy
  • Tested metadata extraction with problematic URLs (e.g., https://www.irs.gov/wheres-my-refund) - title and metadata now extract correctly
  • Ran the existing test suite to ensure no regressions
  • Tested various scraping scenarios, including:
    • Image extraction and scoring
    • Table detection and extraction
    • Link categorization (internal/external)
    • Content filtering with CSS selectors
    • Media extraction with contextual descriptions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added/updated unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

ntohidi added 2 commits May 27, 2025 17:32
@ntohidi
Refactor content scraping strategies: comment out WebScrapingStrategy…
bfec515 
… references and update to use LXMLWebScrapingStrategy across multiple files. Bring WebScrapingStrategy methods to LXMLWebScrapingStrategy
@ntohidi
fix(metadata): improve title extraction with fallbacks for edge cases…
2b3b728 
…. REF #995

Some pages include a <title> tag in HTML but lxml fails to parse it due to unusual structure.
Added fallback logic using .find() and OpenGraph/Twitter meta tags to ensure reliable title extraction.
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ntohidi ntohidi mentioned this pull request Jun 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ntohidi