-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use strong types for key and bare item integer, decimal, token, and string #137
Draft
apasel422
wants to merge
8
commits into
undef1nd:main
Choose a base branch
from
apasel422:types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes integer serialization infallible.
This makes token serialization infallible.
This makes string serialization infallible.
This makes key serialization infallible.
We remove the rust_decimal dependency and use scaled integers instead. This makes decimal and all bare-item serialization infallible.
This enables us to use structure-aware fuzzing for more efficient coverage of serialize/parse roundtripping. https://rust-fuzz.github.io/book/cargo-fuzz/structure-aware-fuzzing.html
CC @valenting |
I'm AFK until Thursday. If you're in a rush to land let me know and I can delegate. |
Definitely no rush, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #102 that takes the following approach:
BareItem
andRefBareItem
contain only fully validated types.Into
andTryInto
simplify creation of these types from unvalidated inputs, including at compile-time usingconst fn
.rust_decimal::Decimal
is replaced with ansfv::Decimal
type that simply wraps the newInteger
type, as an SFV decimal is 12 integral digits and 3 fractional digits, while an SFV integer is 15 decimal digits.sfv::{Key, String, Token}
types are the owned equivalents of the newsfv::{KeyRef, StringRef, TokenRef}
types, analogous toVec<T>
vs[T]
.As part of #119, we will likewise introduce an
sfv::Date
type that wrapsInteger
.Fixes #98