-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.15.0 PR #674
Merged
Merged
V2.15.0 PR #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update timeField to record time of deposition of sediment in SP functions
Fix typo in 3D surface. Also reset time of the air material to the model time
fixed typo in func
Simplify 2D velocity and diffusivity SP functions
Didn't create object to bcast surface function to
Revert back to MPI gather of data over evaluate_global Update the examples
Changes also include: * Renaming the surface tracers to prevent unexpected overwrites * The surfaceProcess class saving the passive tracer key to use during initialisation and solve. This is to make the code not save an instance of the pt to the swarm incase the pt is swapped in/out of Model memory. And helps with code readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.