Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 570 / Fix highlighting errors with right quote in Greek Word #181

Merged
merged 17 commits into from
Dec 4, 2023
Merged

Bugfix 570 / Fix highlighting errors with right quote in Greek Word #181

merged 17 commits into from
Dec 4, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Nov 23, 2023 •
edited
Loading

Describe what your pull request addresses (Please include relevant issue numbers):

  • fixed highlighting for original language words using right quote characters
  • fixed useEffect dependency and added more checks to make sure values are defined
  • updated dependencies
  • fixed unit tests

Please include detailed Test instructions for your pull request:

@PhotoNomad0 PhotoNomad0 changed the title Bugfix 570 / Fix highlighting errors Bugfix 570 / Fix highlighting errors with right quote in Greek Word Nov 23, 2023
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review November 29, 2023 01:04
kintsoogi
kintsoogi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/components/verse-objects/AlignedWordsObject.js Outdated Show resolved Hide resolved
@PhotoNomad0 PhotoNomad0 merged commit 07d5069 into master Dec 4, 2023
4 of 5 checks passed
@PhotoNomad0 PhotoNomad0 deleted the bugfix-mcleanb-570-highlightingErrors branch May 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kintsoogi kintsoogi kintsoogi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhotoNomad0 @kintsoogi