Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 534 / Fix lexicon popup to make it easier to select text #183

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Bugfix 534 / Fix lexicon popup to make it easier to select text #183

merged 2 commits into from
Dec 7, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Dec 4, 2023 •
edited
Loading

Describe what your pull request addresses

  • in scripture panes, added a delay before lexicon popup is displayed on hover
  • in scripture panes, lexicon popup is not shown if mouse button is already down when moving over

Test Instructions

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review December 7, 2023 15:16
kintsoogi
kintsoogi approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kintsoogi kintsoogi merged commit f6c2763 into master Dec 7, 2023
4 of 5 checks passed
@kintsoogi kintsoogi deleted the bugfix-mcleanb-hoverFix branch December 7, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kintsoogi kintsoogi kintsoogi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhotoNomad0 @kintsoogi