-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permalinks Feature - Abel #1281
base: develop
Are you sure you want to change the base?
Permalinks Feature - Abel #1281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job adding this feature. Looking for things that stood out.
We found some useEffects and useCallbacks that used objects and arrays in dependencies which should use the DeepCompare versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Exciting to see this feature added.
There is a lot more code added here that seems tied to implementation of the DCS API that was autogenerated by Gitea. What are your thoughts on creating a DCS API React Hooks library that can abstract all of the related hooks? A feature like this should be reusable in other apps and not limited to just this app.
Would like to schedule a meeting to discuss the DCS-API and how that avoids conflicts with the GiteaReactToolkit that is already implemented. We can also discuss how we might start abstracting the DCS-API hooks so that we can use them in other apps. Again, Great job! |
Stage 1:
Added base permalink functionality.
To do: