Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks Feature - Abel #1281

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented May 17, 2022

Stage 1:

Added base permalink functionality.

  • The application loads the state from local and then compares it with the URL and, if there is a partial match, it uses the data from the local and loads the rest from the DCS API.
  • App listens for the context state change and changes the permalink accordingly if necessary (if the user interacts with the ApplicationStepper component the URL will change accordingly).
  • A feature has been added to allow TSVs to be searchable via URL queries.

To do:

  • Enable the app to navigate back and load previous state from History.state.
  • Improve performance, and perception of performance (partial rendering of the layout until all data is loaded).

@abelpz abelpz marked this pull request as ready for review May 22, 2022 04:08
@abelpz abelpz marked this pull request as draft May 22, 2022 04:09
Copy link
Collaborator

@Joel-C-Johnson Joel-C-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job adding this feature. Looking for things that stood out.
We found some useEffects and useCallbacks that used objects and arrays in dependencies which should use the DeepCompare versions

src/components/translatable/TranslatableTSV.js Outdated Show resolved Hide resolved
src/components/translatable/TranslatableTSV.js Outdated Show resolved Hide resolved
src/features/permalinks/PermalinksHandler.js Show resolved Hide resolved
src/features/permalinks/useFormattedLink.js Outdated Show resolved Hide resolved
src/features/permalinks/usePermalinksState.js Outdated Show resolved Hide resolved
src/features/permalinks/usePermalinksState.js Outdated Show resolved Hide resolved
newrelic_agent.log Outdated Show resolved Hide resolved
Copy link
Contributor

@klappy klappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Exciting to see this feature added.

There is a lot more code added here that seems tied to implementation of the DCS API that was autogenerated by Gitea. What are your thoughts on creating a DCS API React Hooks library that can abstract all of the related hooks? A feature like this should be reusable in other apps and not limited to just this app.

src/App.js Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/components/translatable/TranslatableTSV.js Outdated Show resolved Hide resolved
src/components/translatable/TranslatableTSV.js Outdated Show resolved Hide resolved
@klappy klappy marked this pull request as ready for review June 1, 2022 17:00
@klappy
Copy link
Contributor

klappy commented Jun 1, 2022

Would like to schedule a meeting to discuss the DCS-API and how that avoids conflicts with the GiteaReactToolkit that is already implemented.

We can also discuss how we might start abstracting the DCS-API hooks so that we can use them in other apps.

Again, Great job!

src/App.js Show resolved Hide resolved
@abelpz abelpz requested review from klappy and Joel-C-Johnson June 6, 2022 14:41
@abelpz abelpz marked this pull request as draft June 7, 2022 12:11
@abelpz abelpz marked this pull request as ready for review June 11, 2022 13:01
@abelpz abelpz marked this pull request as draft June 14, 2022 12:47
@abelpz abelpz marked this pull request as ready for review June 30, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants