Fix "reference to Record is ambiguous" build error on JDK 16 and above #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Java 16, a new java.lang.Record class has been added to the Java
SE API. Classes under the java.lang package, including this Record
class, are automatically imported in any Java source file. Because this
project also has a com.univocity.parsers.common.record.Record interface,
when it is being compiled on JDK 16 and above, there would be an
ambiguity as to which class/interface to use for the 'Record' type:
src/main/java/com/univocity/parsers/common/Context.java:136: error: reference to Record is ambiguous
Record toRecord(String[] row);
^
both interface com.univocity.parsers.common.record.Record in com.univocity.parsers.common.record and class java.lang.Record in java.lang match
The resolution to this issue is simply to import the Record interface
under this project explicitly in every source file using it.
Bug: Leo3418/junit-5-ebuild-repo#4
Reported-by: Volkmar W. Pogatzki <[email protected]>
Signed-off-by: Yuan Liao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit in this pull request fixes compiler errors like the following one when this project is being built using JDK 16 or above:
More details are explained in the commit message.
Although this project's
pom.xmlstill declares Java 1.6 as the compilation source/target, which means that it cannot be built using JDK 12+ yet, this change would still make this project more future-proof under all circumstances. It eliminates one issue you folks would encounter when you decide to support JDK 17 for the latest LTS release of Java. Even if you wish to stay on older Java versions for an extended period, this commit is backward-compatible with older JDK versions and does not introduce any regression both theoretically and practically according to my testing.For what it is worth, the aforementioned compiler errors were discovered when we packaged this project for a GNU/Linux distribution (Leo3418/junit-5-ebuild-repo#4). We, as distribution maintainers, often use a more up-to-date version of JDK to build packages for various Java projects:
Therefore, we, as maintainers of those distributions, would appreciate your attention to support for the newer JDK versions.