Fix code scanning alert no. 1: Bad HTML filtering regexp #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/hope_country_report/apps/power_query/static/admin/power_query/codemirror/xml.js
Fixed
Show fixed
Hide fixed
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
| else return null; | ||
| } else if (stream.match("--")) { | ||
| return chain(inBlock("comment", "-->")); | ||
| return chain(inBlock("comment", /-->/, /--(?:!>)/)); |
Check failure
Code scanning / CodeQL
Bad HTML filtering regexp High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 23 days ago
To fix the problem, we need to update the regular expression used to match the end of HTML comments to account for the alternative valid end tag --!>. This can be done by modifying the regular expression to match both --> and --!>. The best way to fix this without changing existing functionality is to update the regular expression on line 82.
Suggested changeset
1
src/hope_country_report/apps/power_query/static/admin/power_query/codemirror/xml.js
| @@ -81,3 +81,3 @@ | ||
| } else if (stream.match("--")) { | ||
| return chain(inBlock("comment", /-->/, /--(?:!>)/)); | ||
| return chain(inBlock("comment", /-->/, /--(?:!>|>)/)); | ||
| } else if (stream.match("DOCTYPE", true, true)) { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/unicef/hope-country-report/security/code-scanning/1
To fix the problem, we need to update the regular expression used to match the end of HTML comments to account for the
--!>variant. This can be done by modifying theinBlockfunction to recognize both-->and--!>as valid end tags for comments.inBlockfunction to handle both-->and--!>as valid end tags for comments.inTextfunction to use the updatedinBlockfunction.Suggested fixes powered by Copilot Autofix. Review carefully before merging.