Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Poll choices with surrounding spaces #1422

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Fix Poll choices with surrounding spaces #1422

wants to merge 14 commits into from

Conversation

Alihassanc5
Copy link
Collaborator

@Alihassanc5 Alihassanc5 commented Oct 11, 2022 •
edited by sheralim012
Loading

Closes #1421

  • There was an issue of duplicates when questionnaires choices are submitted with surrounding spaces
  • Strip surrounding spaces for choices

image

@Alihassanc5 Alihassanc5 marked this pull request as ready for review October 17, 2022 12:00
@sheralim012 sheralim012 marked this pull request as draft December 26, 2022 16:29
@Alihassanc5 Alihassanc5 changed the title Fix questionnaires choices with surrounding spaces Fix Poll choices with surrounding spaces Jan 6, 2023
@sheralim012 sheralim012 force-pushed the fix/choices-with-surrounding-spaces branch from 46fa662 to 0814bb9 Compare January 6, 2023 20:08
@sheralim012 sheralim012 marked this pull request as ready for review January 6, 2023 20:35
@istride
Copy link
Contributor

istride commented May 31, 2023

Please prepare this PR for review. At the very least:

  • merge latest develop branch into this branch
  • inspect the PR to make sure this is still a good way to solve the underlying problem

@Alihassanc5
Copy link
Collaborator Author

@istride the latest develop is merged with minor changes, I think it's still a good way to solve this problem.

@Alihassanc5 Alihassanc5 requested a review from istride June 19, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istride istride Awaiting requested review from istride

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Questionnaires choices with surrounding spaces issue
3 participants
@Alihassanc5 @istride @sheralim012